Fixed Hardcoded phrase

[cimad]

Affected version

2.0.1

Hi,

I found this hardcoded phrase. Appear on templates and phrases, when i use 'CTRL + F'


Regards

 

[Chris D]

That text isn't part of the XF software, but instead the Code Mirror editor.

It may be possible for us to provide a way to translate those using the phrase system though.

 

[cimad]

I understand that it will be similar to the translations of Froala editor .

Thanks for the reply and I'll be waiting.

 

[Chris D]

Unfortunately CodeMirror doesn't have any translatable elements and any English text used is hard coded, as far as I can tell.

I've created an issue for this here:

https://github.com/codemirror/CodeMirror/issues/5210

If they're open to the idea of us forking the code, implementing a "Froala type system" for translating and then accepting that into the main CodeMirror release then we'll do that. Otherwise, we might have to either just accept this isn't translatable or fork and write the implementation ourselves, and then maintain it going forward (which wouldn't be ideal).

 

[Kier]

We've now written a language independence system for CodeMirror, and we are waiting for it to (hopefully) be integrated into CodeMirror itself, at which point this issue will disappear and CodeMirror will make use of XF phrases.

 

[Kier]

https://github.com/codemirror/CodeMirror/pull/5531

 

[Kier]

CodeMirror has accepted the updates, this issue is now fixed.