As designed Handle approval queue record on merge

[MilkyMeda]

Affected version

2.2.1

Merging unapproved thread with an approved one leaves the approval queue record untouched and the content visible. This may apply to posts and other content types too.

 

[Mike]

I'm not able to reproduce this and I don't see why it would happen unless there's an add-on involved. The approval queue record should be cleaned up when the source thread is deleted.

Please confirm with add-ons disabled and if you can reproduce it, please provide exact steps to trigger it.

 

[MilkyMeda]

Well, try leaving a redirect while merging.

 

[Mike]

Well in that case the source thread does indeed remain unapproved, but that's just the redirect itself. That record can be approved/deleted via the approval queue as expected.

Arguably we could change something, but it doesn't appear to be leaving anything in an inconsistent state.

 

[MilkyMeda]

It does actually. If you have the redirected URL you can go where it leads to even if that redirect is in the approval queue and unapproving a redirect isn't possible so approving it doesn't make sense for me. I'm doing something for nothing.