Fixed Error with template modifications for non existing templates

[Jake B.]

Affected version

2.0.0 Beta 4

For example, with Bookmarks an error is thrown when installing if you don't have XFMG and XFRM installed

  [ErrorException]                      
  Trying to get property of non-object  
                                        

Exception trace:
 () at /Users/jakebooher/Sites/xf2/src/XF/Entity/TemplateModification.php:57
 XF::handlePhpError() at /Users/jakebooher/Sites/xf2/src/XF/Entity/TemplateModification.php:57
 XF\Entity\TemplateModification->reparseTemplate() at /Users/jakebooher/Sites/xf2/src/XF/Entity/TemplateModification.php:123
 XF\Entity\TemplateModification->_postSave() at /Users/jakebooher/Sites/xf2/src/XF/Mvc/Entity/Entity.php:1482
 XF\Mvc\Entity\Entity->save() at /Users/jakebooher/Sites/xf2/src/XF/DevelopmentOutput/TemplateModification.php:70
 XF\DevelopmentOutput\TemplateModification->import() at /Users/jakebooher/Sites/xf2/src/XF/DevelopmentOutput.php:46
 XF\DevelopmentOutput->import() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/AbstractImportCommand.php:25
 XF\Cli\Command\Development\AbstractImportCommand->importData() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/AbstractImportCommand.php:137
 XF\Cli\Command\Development\AbstractImportCommand->importDataForAddOn() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/AbstractImportCommand.php:99
 XF\Cli\Command\Development\AbstractImportCommand->importDataForType() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/AbstractImportCommand.php:64
 XF\Cli\Command\Development\AbstractImportCommand->executeType() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/AbstractImportCommand.php:47
 XF\Cli\Command\Development\AbstractImportCommand->execute() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Command/Command.php:266
 Symfony\Component\Console\Command\Command->run() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/RequiresDevModeTrait.php:20
 XF\Cli\Command\Development\AbstractImportCommand->run() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/Import.php:71
 XF\Cli\Command\Development\Import->execute() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Command/Command.php:266
 Symfony\Component\Console\Command\Command->run() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/Development/RequiresDevModeTrait.php:20
 XF\Cli\Command\Development\Import->run() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/AddOnActionTrait.php:162
 XF\Cli\Command\AddOnInstall->importAddOnData() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Command/AddOnInstall.php:81
 XF\Cli\Command\AddOnInstall->execute() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Command/Command.php:266
 Symfony\Component\Console\Command\Command->run() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Application.php:875
 Symfony\Component\Console\Application->doRunCommand() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Application.php:204
 Symfony\Component\Console\Application->doRun() at /Users/jakebooher/Sites/xf2/src/vendor/symfony/console/Application.php:122
 Symfony\Component\Console\Application->run() at /Users/jakebooher/Sites/xf2/src/XF/Cli/Runner.php:63
 XF\Cli\Runner->run() at /Users/jakebooher/Sites/xf2/cmd.php:15

xf:addon-install [-f|--force] [--] <id>

 

[Mike]

This is fixed now, thanks.