Fixed Do not prevent add-on install if a template modification fails to apply

[Xon]

Affected version

2.0.4

If there is a syntax error due to a template modification instead of being disabled, the install process fails with a 100% useless error message.

Additionally, please include the template modification key for any errors generated when parsing a template so there is some indication of what is wrong

Error message:

[XF\PrintableException]
Line 107: Syntax error


Exception trace:
() at /var/forum/v2/src/XF/Mvc/Entity/Entity.php:1091
XF\Mvc\Entity\Entity->save() at /var/www/html/src/XF/Entity/TemplateModification.php:103
XF\Entity\TemplateModification->reparseTemplate() at /var/www/html/src/XF/Entity/TemplateModification.php:153
XF\Entity\TemplateModification->_postSave() at /var/forum/v2/src/XF/Mvc/Entity/Entity.php:1145
XF\Mvc\Entity\Entity->save() at /var/www/html/src/XF/AddOn/DataType/TemplateModification.php:78
XF\AddOn\DataType\TemplateModification->importAddOnData() at /var/www/html/src/XF/Job/AddOnData.php:108
XF\Job\AddOnData->run() at /var/www/html/src/XF/Job/Manager.php:241
XF\Job\Manager->runJobInternal() at /var/www/html/src/XF/Job/Manager.php:187
XF\Job\Manager->runJobEntry() at /var/www/html/src/XF/Job/Manager.php:138
XF\Job\Manager->runUnique() at /var/www/html/src/XF/Cli/Command/JobRunnerTrait.php:30
XF\Cli\Command\AddOnSubAction->runJob() at /var/www/html/src/XF/Cli/Command/JobRunnerTrait.php:13
XF\Cli\Command\AddOnSubAction->setupAndRunJob() at /var/www/html/src/XF/Cli/Command/AddOnActionTrait.php:164
XF\Cli\Command\AddOnSubAction->importAddOnData() at /var/www/html/src/XF/Cli/Command/AddOnSubAction.php:62
XF\Cli\Command\AddOnSubAction->execute() at /var/www/html/src/vendor/symfony/console/Command/Command.php:242
Symfony\Component\Console\Command\Command->run() at /var/www/html/src/vendor/symfony/console/Application.php:843
Symfony\Component\Console\Application->doRunCommand() at /var/www/html/src/vendor/symfony/console/Application.php:193
Symfony\Component\Console\Application->doRun() at /var/www/html/src/vendor/symfony/console/Application.php:117
Symfony\Component\Console\Application->run() at /var/www/html/src/XF/Cli/Runner.php:63
XF\Cli\Runner->run() at /var/forum/v2/cmd.php:15

 

[Mike]

This is fixed for 2.0.10 now, along with a few related issues that caused some odd displays surrounding template modification error log entries. Template modification conflicts will not block an add-on data import operation; these will be reported as errors on the template modification list. (This is how it worked on some other scenarios.)

Worth mentioning that from a separate change, the error messages generated by the template compiler now include information on the template.