[Endless Horizon] Social Share 2.2.3

[Jaxel]

This addon seems to break all other Facebook Social Plugins... such as Facepiles and Comment Feeds.

Something this addon is doing is preventing XenForo's built in calls for Facebook's Javascript SDK. If other addons or template edits use these built in XenForo features, this addon will break them.

 

[BobbyWibowo]

@Jaxel That's something I had never tested for sure. I'll take a look into that.

 

[Lemminator]

@Jaxel That's something I had never tested for sure. I'll take a look into that.

you can look on my forum when you like ... there was the problem

 

[BobbyWibowo]

@Lemminator Gotcha, I'll get into that in a few hours.

 

[Lemminator]

@Lemminator Gotcha, I'll get into that in a few hours.

you have the login details

thanks for looking into

kind regards

 

[TMC]

This may have been addressed already in this thread but I'm just posting in case it helps someone else - if you're using @Nobita.Kun's Minify HTML and have unticked "Keep HTML Comments?" in its options then the Social Share overlay won't open.

Thanks for the tip. Kept seeing error "ReferenceError: EHSS_sites is not defined" after update in console and was coming to come ask for help, but ticking "Keep HTML Comments" option fixed it.

 

[BobbyWibowo]

Conflict with [Nobita] Minify HTML is added to FAQ for now. I'll try to install the add-on later in my development forum and see if there's any method to bypass that add-on's option while retaining its functionality (I bet people would want to remove comments from their HTML if possible anyway).

 

[BobbyWibowo]

@thumped @TMC Can you guys try to update your Social Share with this XML file and let "Keep HTML Comments?" option in [Nobita] Minify HTML ticked? I only did a small edit to the execution order.

 

[BobbyWibowo]

This addon seems to break all other Facebook Social Plugins... such as Facepiles and Comment Feeds.

Does it only happen with Facepiles and Comment Feeds? I tried to add a new widget with Facebook Page Plugin into my development forum, so basically using this:

<div class="fb-page"
  data-href="https://www.facebook.com/facebook"
  data-width="380"
  data-hide-cover="false"
  data-show-facepile="false"
  data-show-posts="false"></div>

without adding any other JavaScript files and/or settings, and it loaded just fine alongside this add-on.

 

[Lemminator]

@BobbyWibowo you can test it on my site when you like

 

[BobbyWibowo]

@Lemminator I see no issue with Facebook Page Plugin (I added a widget which was only visible to Elnino account) and Social Share.

 

[Lemminator]

@BobbyWibowo this is not the problem .. the problem is in the article (threads) the Facebook comments filed is gone ...

look here https://www.elnino-onlinegaming.de/threads/battlefield-1-bekommt-neue-eliteklasse.944/#post-3862

normally is on there position the Facebook comments displayed

 

[BobbyWibowo]

Yeah, I noticed just now. I'll try to look into this more in my dev forum.

 

[BobbyWibowo]

I don't get it. It works fine on my dev forum (albeit using my site's thread page instead) but it won't work on yours.

 

[Lemminator]

Oh no there are not good News

 

[BobbyWibowo]

@Lemminator Here's a test Facebook Comments on my live forum (it's locked for now though):

And as you can see, it works just fine

 

[Lemminator]

@Lemminator Here's a test Facebook Comments on my live forum (it's locked for now though):
View attachment 146821
And as you can see, it works just fine

@Jaxel have you some idea about my problem ?

 

[Lemminator]

@Lemminator Here's a test Facebook Comments on my live forum (it's locked for now though):
View attachment 146821
And as you can see, it works just fine

is it eventually working because it is not in a thread ? can you test it in a thread on the bottom ?

 

[BobbyWibowo]

is it eventually working because it is not in a thread ? can you test it in a thread on the bottom ?

Yeah, doesn't work on mine either. Sigh~ just what is the cause I wonder.. I'll try to look into this more, but it may take quite a while since I couldn't find a lead on Google either.

 

[Jaxel]

If you include the Javascript SDK directly above the fb-widget call... it works. However, you should not have to do this. I don't do this in ANY of my mods. XenForo already includes the Javascript SDK. Including it with each widget would just be redundant.

Put the widget in without the SDK include and you'll see it breaks.