Fixed Email length inconsistencies

[AlexT]

In the xf_user db table, email is defined as VARCHAR(120). The user datawriter defines maxLength for emails as 120 (which is consistent with the value in xf_user).

But in xf_ban_email, email is defined as VARCHAR(50).

Furthermore, according to RFCs, the upper limit of email address length should really be 254 characters.

http://www.rfc-editor.org/errata_search.php?rfc=3696&eid=1690

http://tools.ietf.org/html/rfc5321

 

[Mike]

I've changed the banned email table for 1.2.

The 120 was picked as a bit of a compromise, as we didn't want the full overhead of a 254 character email, plus that length is really mostly dominated by something like a 160 character domain name. I don't have any plans to change that (and if anything, we probably could've picked something smaller).