1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed editor_dialog_media invalid closing tag / unclosed tag

Discussion in 'Resolved Bug Reports' started by Gio~Logist, Sep 13, 2016.

  1. Gio~Logist

    Gio~Logist Member

    In the editor_dialog_media template

    HTML:
    <dl class="ctrlUnit">
        <dt>{xen:phrase enter_media_url}:</dt>
        <dd><input type="text" id="redactor_media_link" class="textCtrl" />
            <div class="explain listInline commaImplode">
                {xen:phrase you_may_embed_media_from_following_sites}:
                <ul>
                <xen:foreach loop="$sites" value="$site" count="$totalSites" i="$i">
                    <xen:if is="{$site.supported}">
                        <li><a href="{$site.site_url}" target="_blank" rel="nofollow">{$site.site_title}</a></li>
                    </xen:if>
                </xen:foreach>
                </ul>
            </div>
        </dd>
    </dl>
    
    <dl class="ctrlUnit submitUnit">
        <dt></dt>
        <dd>
            <input type="button" name="upload" class="redactor_modal_btn button primary" id="redactor_insert_media_btn" value="{xen:phrase embed}" />
            <a href="javascript:void(null);" class="redactor_modal_btn redactor_btn_modal_close button">{xen:phrase cancel}</a>
        </dd>
    </dd>

    The final </dd> should actually be </dl>

    At the moment submitUnit remains unclosed.
     
    Zenexer likes this.
  2. Mike

    Mike XenForo Developer Staff Member

    This was actually a problem in most of the editor dialog templates. I've fixed all of them now, thanks.
     
    Gio~Logist likes this.
  3. Gio~Logist

    Gio~Logist Member

    Yea, hah - I noticed that people who were developing plugins also followed this "technique" lmao. I'll try and remind myself to let those I found know.
     

Share This Page