XF 2.1 Editor problems

[Lee]

After upgrading to 2.1 RC1 my quick reply editor has stopped loading the BBCode tool bar. This can be replicated on the default xenforo theme.

Likewise, if I click reply - the AJAX loading notification appears but nothing happens.

I see this in the console window:

jquery.min.js:2 Uncaught TypeError: Cannot read property 'icon' of undefined
    at s.html (editor-compiled.js?_v=1039ebb9:164)
    at editor-compiled.js?_v=1039ebb9:7
    at g (editor-compiled.js?_v=1039ebb9:7)
    at Object.buildList (editor-compiled.js?_v=1039ebb9:7)
    at editor-compiled.js?_v=1039ebb9:7
    at p (editor-compiled.js?_v=1039ebb9:7)
    at Object._init (editor-compiled.js?_v=1039ebb9:7)
    at s.load (editor-compiled.js?_v=1039ebb9:7)
    at s.<anonymous> (editor-compiled.js?_v=1039ebb9:7)
    at HTMLTextAreaElement.i (jquery.min.js:2)
html @ editor-compiled.js?_v=1039ebb9:164
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
g @ editor-compiled.js?_v=1039ebb9:7
buildList @ editor-compiled.js?_v=1039ebb9:7
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
p @ editor-compiled.js?_v=1039ebb9:7
_init @ editor-compiled.js?_v=1039ebb9:7
s.load @ editor-compiled.js?_v=1039ebb9:7
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
i @ jquery.min.js:2
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2
trigger @ jquery.min.js:2
(anonymous) @ jquery.min.js:2
each @ jquery.min.js:2
each @ jquery.min.js:2
trigger @ jquery.min.js:2
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
i @ jquery.min.js:2
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
i @ jquery.min.js:2
s._init @ editor-compiled.js?_v=1039ebb9:7
s @ editor-compiled.js?_v=1039ebb9:7
(anonymous) @ editor-compiled.js?_v=1039ebb9:7
each @ jquery.min.js:2
each @ jquery.min.js:2
M.fn.froalaEditor @ editor-compiled.js?_v=1039ebb9:7
startInit @ editor-compiled.js?_v=1039ebb9:103
init @ editor-compiled.js?_v=1039ebb9:102
c @ core-compiled.js?_v=1039ebb9:140
e @ core-compiled.js?_v=1039ebb9:140
(anonymous) @ core-compiled.js?_v=1039ebb9:140
each @ jquery.min.js:2
each @ jquery.min.js:2
f @ core-compiled.js?_v=1039ebb9:140
activate @ core-compiled.js?_v=1039ebb9:44
onPageLoad @ core-compiled.js?_v=1039ebb9:25
l @ jquery.min.js:2
c @ jquery.min.js:2
setTimeout (async)
w.readyException @ jquery.min.js:2
(anonymous) @ jquery.min.js:2
l @ jquery.min.js:2
c @ jquery.min.js:2
setTimeout (async)
(anonymous) @ jquery.min.js:2
u @ jquery.min.js:2
fireWith @ jquery.min.js:2
fire @ jquery.min.js:2
u @ jquery.min.js:2
fireWith @ jquery.min.js:2
c @ jquery.min.js:2
setTimeout (async)
(anonymous) @ jquery.min.js:2
u @ jquery.min.js:2
fireWith @ jquery.min.js:2
fire @ jquery.min.js:2
u @ jquery.min.js:2
fireWith @ jquery.min.js:2
ready @ jquery.min.js:2
_ @ jquery.min.js:2
favicon.ico:1 GET https://www.lifespot.us/favicon.ico 404 (Not Found)
editor-compiled.js?_v=1039ebb9:129 Uncaught TypeError: Cannot read property 'bbCode' of null
    at c.isBbCodeView (editor-compiled.js?_v=1039ebb9:129)
    at c.scrollToCursor (editor-compiled.js?_v=1039ebb9:130)
    at Object.focusEditor (core-compiled.js?_v=1039ebb9:59)
    at click (message.min.js?_v=1039ebb9:11)
    at c._onEvent (core-compiled.js?_v=1039ebb9:136)
    at c (core-compiled.js?_v=1039ebb9:134)
    at HTMLAnchorElement.<anonymous> (core-compiled.js?_v=1039ebb9:137)
    at HTMLDocument.dispatch (jquery.min.js:2)
    at HTMLDocument.y.handle (jquery.min.js:2)
isBbCodeView @ editor-compiled.js?_v=1039ebb9:129
scrollToCursor @ editor-compiled.js?_v=1039ebb9:130
focusEditor @ core-compiled.js?_v=1039ebb9:59
click @ message.min.js?_v=1039ebb9:11
_onEvent @ core-compiled.js?_v=1039ebb9:136
c @ core-compiled.js?_v=1039ebb9:134
(anonymous) @ core-compiled.js?_v=1039ebb9:137
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2
editor-compiled.js?_v=1039ebb9:129 Uncaught TypeError: Cannot read property 'bbCode' of null
    at c.isBbCodeView (editor-compiled.js?_v=1039ebb9:129)
    at Object.modifyEditorContent (core-compiled.js?_v=1039ebb9:58)
    at Object.insertIntoEditor (core-compiled.js?_v=1039ebb9:57)
    at c.handleAjax (message.min.js?_v=1039ebb9:12)
    at core-compiled.js?_v=1039ebb9:72
    at Object.r [as success] (core-compiled.js?_v=1039ebb9:40)
    at u (jquery.min.js:2)
    at Object.fireWith [as resolveWith] (jquery.min.js:2)
    at k (jquery.min.js:2)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2)

 

[Lee]

Just to confirm, upgrading to RC2 did not fix this.

 

[Lee]

Sorry for the reply, other things like the edit button and multi-quote AJAX does not work either.

 

[Paul B]

Try hard refreshing your browser - it may be an issue with cached JS.

 

[Lee]

Try hard refreshing your browser - it may be an issue with cached JS.

Hi Brogan, no joy.

The entire BBCode tool bar is missing from any editor window.

 

[Paul B]

Try running a file health check.

It sounds like there are fundamental JS issues.

Out of interest, what version of PHP is the server running?

 

[Mike]

I can track the code here but I'm not totally sure why it's happening. If you go to the BB code button manager, what dropdowns do you have defined?

 

[Lee]

Attached some screenshots.

The file check was healthy.






As you can see the editor doesn't look right. Worked right up until the upgrade to RC1.

 

[Lee]

I can track the code here but I'm not totally sure why it's happening. If you go to the BB code button manager, what dropdowns do you have defined?

I have the Insert and List drop downs.

 

[Lee]

I can track the code here but I'm not totally sure why it's happening. If you go to the BB code button manager, what dropdowns do you have defined?

If I disable the drop downs, the editor works again

 

[Paul B]

Does the toolbar appear if you disabled the drop down items?

Edit: Heh! You posted that just as I was asking.

 

[Mike]

Do you have any add-ons that try to add buttons, particularly to the insert menu?

I have applied some code changes that will prevent the error; I'd just like to know how it happens.

 

[Lee]

Yes, Giphy by Themehouse. But I have it disabled right now.

All I have enabled is a beta of UI.x 2 for 2.1 Covers by Themehouse, Amazon S3 for XenForo and Threadloom search enhancement.

 

[Mike]

Depending on implementation, that add-on being disabled may be the cause, as it's likely the button is still present in your configuration.

Should be resolved for the next release anyway.

 

[Lee]

Depending on implementation, that add-on being disabled may be the cause, as it's likely the button is still present in your configuration.

Should be resolved for the next release anyway.

Is this a xenforo bug or something I should make themehouse aware of?

 

[Mike]

XF bug I believe.