• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

As designed Different reaction at move threads in the same forum

Romchik®

Well-known member
#1
Small bug (1.0.4).

First way.
move-1.png
Forum report an error. Everything is logical and correct.
All selected threads are already in the destination forum. Please select another forum.
Second way.
move-2.png
Nothing happens. And where is the error? :)
 

Jake Bunce

XenForo moderator
Staff member
#2
Those two move actions are handled differently:

Inline moderation - XenForo_Model_InlineMod_Thread::moveThreads
Thread tools - XenForo_ControllerPublic_Thread::actionMove

The thread tools option doesn't error when the destination is the same, unlike inline moderation.

I would say the check is more important for inline moderation because completing the action results in the inline selections being cleared. Compare that with thread tools where nothing is lost in completing the null move, and an error message wastes no less time than opening the thread again or clicking back in your browser. Nothing is gained by adding a new error message.