Development mode + web-installer can result in add-ons being unexpectedly broken

X

Xon

Well-known member
Affected version
2.2.13
If a user has enabled development mode, the web-installer for add-ons becomes a nasty footgun which can break add-ons and is deeply confusing for users and developers. The root of the issue is when development mode is enabled, _output will be partially updated it some parts of the add-on's data is touched/modified.

The web installer will deploy the new _data from the add-on zip but these new files will be completely ignored if _output exists. There is no warning, just a deeply broken add-on.

IMO; If someone upload a zip via the web installer, any existing _output folder for the add-on should be removed before the add-on installer is run. And display a warning about development being enabled.
 
Last edited:

Similar threads

L
XF 2.1 Adding new permissions to the resource manager and media gallery add-ons
Replies
5
Views
804
Lawrence
L
X
Fixed Installer difference in _output vs _data installer; Extend custom field types causes error
Replies
1
Views
1K
XF Bug Bot
XF Bug Bot
Earl
Not a bug xf-dev:generate-phpstorm-meta not skipping add-ons in $config['development']['skipAddOns']= [];
Replies
2
Views
988
Chris D
Chris D
X
Fixed Unexpectedly high CPU usage during add-on install - CSS repeatedly invalidated
Replies
5
Views
1K
Mike
Mike
X
Fixed Jobs triggered by CLI add-on enable/disable run in the context of the add-on being disabled
Replies
1
Views
1K
XF Bug Bot
XF Bug Bot
Top Bottom