It does. You should always update addons using the archive manager, as opposed to manually uploading.
Thanks, upgraded successfully. I've never used the archive manager so will make note to use it more often.
ISSUE 1:
Trying to Test digest using my own admin as test user I get this now:
TypeError: Return value of DBTech\Mail\DigestContent\AbstractHandler::getUserSetting() must be of the type array or null, bool returned in
src/addons/DBTech/Mail/DigestContent/AbstractHandler.php at line
124
- DBTech\Mail\DigestContent\AbstractHandler->getUserSetting() in src/addons/DBTech/Mail/DigestContent/Thread.php at line 276
- DBTech\Mail\DigestContent\Thread->getEmailContent() in src/addons/DBTech/Mail/DigestContent/AbstractHandler.php at line 147
- DBTech\Mail\DigestContent\AbstractHandler->getEmailTemplateParams() in src/addons/DBTech/Mail/Job/DigestEmail.php at line 153
- DBTech\Mail\Job\DigestEmail->executeAction() in src/XF/Job/AbstractUserCriteriaJob.php at line 59
- XF\Job\AbstractUserCriteriaJob->run() in src/addons/DBTech/Mail/Job/DigestEmail.php at line 91
- DBTech\Mail\Job\DigestEmail->run() in src/addons/DBTech/Mail/Admin/Controller/Digest.php at line 254
- DBTech\Mail\Admin\Controller\Digest->actionSendTest() in src/XF/Mvc/Dispatcher.php at line 350
- XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
- XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
- XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
- XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2300
- XF\App->run() in src/XF.php at line 488
- XF::runApp() in admin.php at line 13
ISSUE 2:
I also left the digest enabled and got a few of these after the fact:
- XF\Db\Exception: Job DBTech\Mail
igestEmail: MySQL statement prepare error [1054]: Unknown column 'xf_user.dbtech_mail_newsletter_receive' in 'where clause'
- src/XF/Db/AbstractStatement.php:228
- Generated by: Unknown account
- Dec 29, 2020 at 6:50 AM
Stack trace
SELECT
xf_user
.
user_id
FROM
xf_user
LEFT JOIN
xf_user_option
AS
xf_user_option_Option_1
ON (
xf_user_option_Option_1
.
user_id
=
xf_user
.
user_id
)
WHERE (
xf_user
.
user_state
= 'valid') AND (
xf_user
.
is_banned
= 0) AND (
xf_user_option_Option_1
.
is_discouraged
= 0) AND (
xf_user
.
email
<> '') AND (
xf_user
.
dbtech_mail_newsletter_receive
= 1) AND (
xf_user
.
user_id
> 0)
ORDER BY
xf_user
.
user_id
ASC
LIMIT 1000
------------
#0 src/XF/Db/Mysqli/Statement.php(196): XF\Db\AbstractStatement->getException('MySQL statement...', 1054, '42S22')
#1 src/XF/Db/Mysqli/Statement.php(39): XF\Db\Mysqli\Statement->getException('MySQL statement...', 1054, '42S22')
#2 src/XF/Db/Mysqli/Statement.php(54): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(94): XF\Db\Mysqli\Statement->execute()
#4 src/XF/Mvc/Entity/Finder.php(1423): XF\Db\AbstractAdapter->query('
SELECT `xf_...')
#5 src/XF/Mvc/Entity/Finder.php(1438): XF\Mvc\Entity\Finder->fetchRaw(Array)
#6 src/XF/Job/AbstractUserCriteriaJob.php(95): XF\Mvc\Entity\Finder->fetchColumns('user_id')
#7 src/XF/Job/AbstractUserCriteriaJob.php(32): XF\Job\AbstractUserCriteriaJob->prepareUserIds()
#8 src/addons/DBTech/Mail/Job/DigestEmail.php(91): XF\Job\AbstractUserCriteriaJob->run(8)
#9 src/XF/Job/Manager.php(258): DBTech\Mail\Job\DigestEmail->run(8)
#10 src/XF/Job/Manager.php(200): XF\Job\Manager->runJobInternal(Array, 8)
#11 src/XF/Job/Manager.php(84): XF\Job\Manager->runJobEntry(Array, 8)
#12 job.php(43): XF\Job\Manager->runQueue(false, 8)
#13 {main}
array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(70) "
https://mysite.com/threads/complete-8-second-c6.22676/"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}