Fixed DB error from recurring upgrade expiry / recurring upgrade refund not immediately processed

[Mike]

Affected version

1.5.16

Unfortunately, a regression in 1.5.16 has been discovered relating to recurring user upgrades. If you don't use recurring user upgrades, this issue will not affect you.

This can cause two issues:

1. If a recurring upgrade expires and we do not receive notification of a subsequent payment, a DB error may be logged hourly. This should go away after 24 hours and the downgrade will occur.
2. If a recurring upgrade is refunded/reversed or manually downgraded via the control panel, the downgrade won't be applied until the user upgrade would naturally expire.

To fix this issue, we have updated the 1.5.16 package to 1.5.16a to indicate that these changes have been included in the release from roughly the time of this message. If you've downloaded 1.5.16a, you don't need to take any further steps.

If you wish to manually patch this issue, you can use the attached patch file to overwrite library/XenForo/Model/UserUpgrade.php.