- Affected version
- 2.3.0 Beta 2 / xenforo.com
This post is just fine in Light but almost unreadable in Dark.
Dark Mode does not work well with [color]
- Thread starter Kirby
- Start date
This post is just fine in Light but almost unreadable in Dark.
I get it. But I'm really not sure we'd be looking to do anything about this.
This is no different than before style variants were a thing and you could set your text color to the same as the post background container. Or set it to a yellow or light blue colour, for example, that might be hard to read on a light background.
I'm leaving this open, but I'm not sure there's a sensible way to solve this problem without removing the ability to set colours in posts at all.
EDIT: I know there's a potential issue with copy/pasting text that already has colours but I think we're already sufficiently removing those on paste (and have done for a while, although it was broken briefly with 2.3).
This is no different than before style variants were a thing and you could set your text color to the same as the post background container. Or set it to a yellow or light blue colour, for example, that might be hard to read on a light background.
I'm leaving this open, but I'm not sure there's a sensible way to solve this problem without removing the ability to set colours in posts at all.
EDIT: I know there's a potential issue with copy/pasting text that already has colours but I think we're already sufficiently removing those on paste (and have done for a while, although it was broken briefly with 2.3).
Light mode also doesn't work well with [COLOR] tags.
This post is just fine in Dark but almost unreadable in Light.
This post is just fine in Dark but almost unreadable in Light.
While it is certainly true that the root issue (users can set an arbitrary text color) has always been there I think that dark mode does make a difference:
Until now there was no dark mode, the default style was just light.
I might be wrong, but I think the majority of forums so far only use dark or light styles.
So if users did use colors, they most likely used colors that were okay with the single background color.
But now three will be dark and light backgrounds; some users will use one variante (and choose colors that work there) while others use the opposite variant.
Depending on the user audience there might be a noticable amount of (existing) posts that use problematic colors and thuse dark mode could amplify the issue.
That was my frist thought as well and this is what I told our community managers (who reached out for me to fix as they got user complaints).
After thinking a bit more about this there might be a way though to still allow at least some colors in posts wihtout running into contrast issues:
What about a new BB Code (
[PALETTECOLOR] or whatever) that allows users to chose from a set of admin defined colors?Instead of directly rendering a specific color, this new BB code would render colors defined by style properties - which could be switched easily when switching mode.
While this doesn't fix issues with
[COLOR] in existing content and does not allow full flexibility it would allow a somewhat clean path to support some colors in user generated content and not run into contrast issues.
Mr Lucky
Well-known member
@Paul B actually meant this post:
This post ist just the opposite of my post, eg. color=white - this is fine in dark mode but unreadable in light mode.
Btw: The "wrong" embed is a perfect example why https://xenforo.com/community/threads/pasting-link-to-reply-goes-to-the-first-post.218472 really needs some love
This post ist just the opposite of my post, eg. color=white - this is fine in dark mode but unreadable in light mode.
Btw: The "wrong" embed is a perfect example why https://xenforo.com/community/threads/pasting-link-to-reply-goes-to-the-first-post.218472 really needs some love
Developers are not interested in this, judging by the messages in this thread https://xenforo.com/community/threa...-contrast-in-light-and-dark-styles-e-g-darken -lighten-the-rendered-color.198237/
The idea of inverting colors is not a bad one, but most likely it’s just possible to ban the use of a tag in messages at the administrator’s discretion.
And it’s really not convenient to read the forum when people set colors and since the installation of the alpha there have been a lot of messages that are not pleasing to the eye or need to be read carefully or something else. As an example here
I just made an add-on that removes this bb-code and removes the color formatting.
MySiteGuy
Well-known member
It should be an easy fix using CSS mix-blend.
developer.mozilla.org
mix-blend-mode - CSS: Cascading Style Sheets | MDN
The mix-blend-mode CSS property sets how an element's content should blend with the content of the element's parent and the element's background.
developer.mozilla.org
That was a specific bug which has now been fixed though. Not retroactively, but the root cause has been fixed so it shouldn't happen any more.
The only cases you will see this happening now is if someone has deliberately used a text colour that doesn't contrast with the background of a specific style variant.
This is cool but could get wonky quickly.It should be an easy fix using CSS mix-blend.
mix-blend-mode - CSS: Cascading Style Sheets | MDN
The mix-blend-mode CSS property sets how an element's content should blend with the content of the element's parent and the element's background.
The thought i had was the possibility of a contrast pass on template save or css save, somewhere. and a warning pop up in the admin panel.
'are you sure you want this color? it's dang close to the background of @postbody' or something like that.
As mentioned, there's no good way to fix it.
There has to be some onus on the user/admin.
But there needs to be visibility that it is an issue so the admin can act accordingly.
If it's inline in a post, perhaps the user can get a prompt -- hey it looks good on white, but others using dark won't be able to see it. Are you sure you want to use that color?
I never use dark and frankly i hadn't considered testing with it.
