1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Code in XenForo_ControllerPublic_Forum

Discussion in 'Resolved Bug Reports' started by xf_phantom, Aug 10, 2013.

  1. xf_phantom

    xf_phantom Well-Known Member

    Line 109 is:

    PHP:
    $fetchElements $this->_getThreadFetchElements(
           
    $forum$displayConditions,
           
    $threadsPerPage$page$order$orderDirection
         
    );
    If you look at _getThreadFetchElements , you'll see that the method has only 2 arguments
    PHP:
    protected function _getThreadFetchElements(array $forum, array $displayConditions)
       {
    It's not throwing an error and we can access the vars via func_get_args BUT that's really ugly AND can break if any addon uses/sends some other arguments after the 2 official arguments


    Bug?
    Intention?
    Only strange code in my environment?
     
    Marcus likes this.
  2. Kier

    Kier XenForo Developer Staff Member

    Not sure why those are there, but they're not used, so I've zapped them.
     
    JulianD likes this.

Share This Page