Lack of interest Helper in XenForo_ControllerPublic_Forum

[Fuhrmann]

$ftpHelper = $this->getHelper('ForumThreadPost');
        $forum = $this->getHelper('ForumThreadPost')->assertForumValidAndViewable(
            $forumId ? $forumId : $forumName,
            $this->_getForumFetchOptions()
        );

Since the helper is already in the var $ftpHelper the line below could be:

$forum = $ftpHelper->assertForumValidAndViewable(
            $forumId ? $forumId : $forumName,
            $this->_getForumFetchOptions()
        );

 

[infis]

And why it in Suggestions, instead of in Bugs?

 

[Floris]

Because he needs more coffee, or more sleep.
hehe

 

[Fuhrmann]

And why it in Suggestions, instead of in Bugs?

Well, maybe I am wrong, but I dont think this is a bug...But sure, Brogan can move to the right place.

And this too

Because he needs more coffee, or more sleep.
hehe

 

[Fuhrmann]

There is something like this in the XenForo_ControllerPublic_Account:

public function actionStopIgnoring()
{
    /* @var $ignoreModel XenForo_Model_UserIgnore */
    $ignoreModel = $this->getModelFromCache('XenForo_Model_UserIgnore');
    $userModel = $this->_getUserModel();
 
    $userId = $this->_input->filterSingle('user_id', XenForo_Input::UINT);
 
    if (empty($userId)|| !($user = $this->_getUserModel()->getUserById($userId)))

The $userModel is not used in this action.

 

[Mike]

I doubt either will be changed with any urgency -- more like if we're in that code and it happens to get cleaned up. There's no real overhead to either.

 

[Fuhrmann]

Just reporting...