1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Lack of Interest Helper in XenForo_ControllerPublic_Forum

Discussion in 'Closed Suggestions' started by Fuhrmann, Dec 6, 2011.

  1. Fuhrmann

    Fuhrmann Well-Known Member

    PHP:
    $ftpHelper $this->getHelper('ForumThreadPost');
            
    $forum $this->getHelper('ForumThreadPost')->assertForumValidAndViewable(
                
    $forumId $forumId $forumName,
                
    $this->_getForumFetchOptions()
            );
    Since the helper is already in the var $ftpHelper the line below could be:

    PHP:
    $forum $ftpHelper->assertForumValidAndViewable(
                
    $forumId $forumId $forumName,
                
    $this->_getForumFetchOptions()
            );
     
    infis likes this.
  2. infis

    infis Well-Known Member

    And why it in Suggestions, instead of in Bugs? :)
     
  3. Floris

    Floris Guest

    Because he needs more coffee, or more sleep.
    hehe
     
    Fuhrmann likes this.
  4. Fuhrmann

    Fuhrmann Well-Known Member

    Well, maybe I am wrong, but I dont think this is a bug...But sure, Brogan can move to the right place.

    And this too

     
    mrGTB and infis like this.
  5. Fuhrmann

    Fuhrmann Well-Known Member

    There is something like this in the XenForo_ControllerPublic_Account:

    PHP:
    public function actionStopIgnoring()
    {
        
    /* @var $ignoreModel XenForo_Model_UserIgnore */
        
    $ignoreModel $this->getModelFromCache('XenForo_Model_UserIgnore');
        
    $userModel $this->_getUserModel();
     
        
    $userId $this->_input->filterSingle('user_id'XenForo_Input::UINT);
     
        if (empty(
    $userId)|| !($user $this->_getUserModel()->getUserById($userId)))
    The $userModel is not used in this action.
     
  6. Mike

    Mike XenForo Developer Staff Member

    I doubt either will be changed with any urgency -- more like if we're in that code and it happens to get cleaned up. There's no real overhead to either.
     
  7. Fuhrmann

    Fuhrmann Well-Known Member

    Just reporting...
     

Share This Page