1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed canRevertContent does not call _canRevertContent

Discussion in 'Resolved Bug Reports' started by Rigel Kentaurus, Sep 6, 2013.

  1. Rigel Kentaurus

    Rigel Kentaurus Well-Known Member

    In XenForo_EditHistoryHandler_Abstract, canRevertContent is implemented as
    PHP:
    public function canRevertContent(array $content, array $viewingUser null)
    {
        
    $this->standardizeViewingUserReference($viewingUser);
        return 
    $this->_canViewHistoryAndContent($content$viewingUser);
    }
    Since the handler has a _canRevertContent method, it would make sense that it called that method, instead of canViewHistoryAndContent. As it stands now, the implemented abstract method is unused.
     
  2. Mike

    Mike XenForo Developer Staff Member

    Good catch. (y)
     

Share This Page