Fixed Cannot move thread with XenForo Redirects for vBulletin 1.0.2 enabled

[Mr Lucky]

Affected version

2.0.2

Apologies if this is considered cross posting. I posted this in the addon discussion, but had no response there and as it's a serious bug and associated with an official XF addon that doesn't have its own bug reporting forum, I am posting here. Hope that's OK, sorry if not...



When I disable the redirect addon I can move a post from one thread to another. If the addon is enabled, I get this:



    ypeError: Argument 2 passed to XF301VB\Mvc\Router::getVbulletin4RewriteMatch() must be an instance of XF\Http\Request, null given, called in /home/caf/public_html/src/addons/XF301VB/Mvc/Router.php on line 72 src/addons/XF301VB/Mvc/Router.php:152


    Generated by: Pete Thomas Feb 28, 2018 at 10:17 AM


Stack trace


#0 src/addons/XF301VB/Mvc/Router.php(72): XF301VB\Mvc\Router->getVbulletin4RewriteMatch('threads', NULL)
#1 src/XF/Repository/Thread.php(328): XF301VB\Mvc\Router->routeToController('threads/drum-be...')
#2 src/XF/InlineMod/Post/AbstractMoveCopy.php(34): XF\Repository\Thread->getThreadFromUrl('https://cafesax...', NULL, NULL)
#3 src/XF/InlineMod/AbstractAction.php(57): XF\InlineMod\Post\AbstractMoveCopy->canApplyInternal(Object(XF\Mvc\Entity\ArrayCollection), Array, NULL)
#4 src/XF/Pub/Controller/InlineMod.php(111): XF\InlineMod\AbstractAction->canApply(Object(XF\Mvc\Entity\ArrayCollection), Array, NULL)
#5 src/XF/Mvc/Dispatcher.php(249): XF\Pub\Controller\InlineMod->actionPerform(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:InlineMod', 'Perform', 'json', Object(XF\Mvc\ParameterBag), '', Object(XF\Pub\Controller\InlineMod), Object(XF\Mvc\Reply\Reroute))
#7 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(1889): XF\Mvc\Dispatcher->run()
#9 src/XF.php(328): XF\App->run()
#10 index.php(13): XF::runApp('XF\\Pub\\App')
#11 {main}


Request state


array(4) {
  ["url"] => string(12) "/inline-mod/"
  ["referrer"] => string(51) "https://cafesaxophone.com/threads/drum-beats.24081/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(11) {
    ["thread_type"] => string(8) "existing"
    ["existing_url"] => string(51) "https://cafesaxophone.com/threads/drum-beats.23986/"
    ["ids"] => array(1) {
      [0] => string(6) "355777"
    }
    ["type"] => string(4) "post"
    ["action"] => string(4) "move"
    ["confirmed"] => string(1) "1"
    ["_xfRedirect"] => string(51) "https://cafesaxophone.com/threads/drum-beats.24081/"
    ["_xfToken"] => string(8) "********"
    ["_xfRequestUri"] => string(26) "/threads/drum-beats.24081/"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}


Delete

 

[Kier]

This looks legit, I'll do a proper investigation on Monday when I'm in bug squishing mode.

 

[Abdurrahim]

search page

An exception occurred: [ErrorException] [E_RECOVERABLE_ERROR] Argument 2 passed to XF301VB\Mvc\Router::getVbulletin5SearchMatch() must be an instance of XF\Http\Request, null given, called in /home/islamtr/public_html/src/addons/XF301VB/Mvc/Router.php on line 103 and defined in src/addons/XF301VB/Mvc/Router.php on line 222

XF::handlePhpError() in src/addons/XF301VB/Mvc/Router.php at line 222
XF301VB\Mvc\Router->getVbulletin5SearchMatch() in src/addons/XF301VB/Mvc/Router.php at line 103
XF301VB\Mvc\Router->routeToController() in src/addons/Tapatalk/Listener/Hook.php at line 600
Tapatalk\Listener\Hook::getCurrentPageType() in src/addons/Tapatalk/Listener/Hook.php at line 40
Tapatalk\Listener\Hook::templateHook()
call_user_func_array() in src/XF/Extension.php at line 35
XF\Extension->fire() in src/XF/App.php at line 2350
XF\App->fire() in src/XF/Template/Templater.php at line 1228
XF\Template\Templater->renderTemplate() in src/XF/Pub/App.php at line 449
XF\Pub\App->renderPageHtml() in src/XF/App.php at line 1724
XF\App->renderPage() in src/XF/Mvc/Dispatcher.php at line 310
XF\Mvc\Dispatcher->render() in src/XF/Mvc/Dispatcher.php at line 44
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1889
XF\App->run() in src/XF.php at line 328
XF::runApp() in index.php at line 13

 

[Kier]

This is fixed in 1.1.1, which is out now.