Batch update users broken in 2.2.12

FTL · Jan 1, 2023

For what it's worth, the bulk update worked for me when I deleted Rejected users, ie spammers (no errors) so this is the first I hear of this issue. I know to wait for a fix now though.

Pawn Studios · Jan 2, 2023

pattycake2 said:
The custom title is not the issue - the actual issue is deeper in the code. Others mentioned commenting out the IF but doing that caused errors. I added the code I did so the script would not fail.

A better solution that seems to work is making a backup of your original, then replace it with an earlier version - I tried 2.2.11 and it worked fine without any code changes except for changing the STATE of the users - I wanted to change the STATE to "bounced email" and that only did the change on about 80 of the 1500 I needed it to.

K a M a L described the issue as $customTitle is never an empty string but instead it gets assigned null which causes the if statement to be faulty as it attempts to filter out empty string as the disallowed value when it should be filtering out null as well which is also equivelant to an empty string in terms of lack of meaningful data.

Therefore combining a null and empty string check should do the trick in this spot.

pattycake2 · Jan 2, 2023

Now that I was able to batch update my secondary group ids, i'm content now waiting for the official release and fix

ActorMike · Jan 19, 2023

I need to batch-update our users to lock dormant accounts. Hopefully, there will be a fix soon as this is a security issue!

Spammers posting through existing accounts with no need to login?

And, worse, with no need of stealing such account. The fact is that since a week ago or so I am getting some spam messages posted by users with little or no activity, but registered years ago. All IP's are located next, and the message is tipically a link to a Telegram channel related to...

xenforo.com

ActorMike · Jan 19, 2023

FTL said:
For what it's worth, the bulk update worked for me when I deleted Rejected users, ie spammers (no errors) so this is the first I hear of this issue. I know to wait for a fix now though.

This did not work for me for batch updating a security lock.

clackey · Jan 19, 2023

ActorMike said:
This did not work for me for batch updating a security lock.

Same for me. Tried on several of my forums using v2.2.12 and no luck. The one time I needed to batch update to stop the spammers from accessing old accounts, can't do it.

Chris D · Jan 19, 2023

For now the recommended workaround is as follows.

Edit src/XF/Job/UserAction.php.

Find:

PHP:

$customTitle = $this->getActionValue('custom_title');
if ($customTitle !== '')
{
   $user->custom_title = $customTitle;
}

Replace with:

PHP:

if ($customTitle = $this->getActionValue('custom_title'))
{
   $user->custom_title = $customTitle;
}

This will flag files with unexpected contents which you can ignore for this file until the next release.

gotski · Jan 20, 2023

Batch update users also stopped working for me when I try to batch delete users from one secondary group and add to another, before update it used to work fine.

htsumer · Feb 18, 2023

Waiting for an update to fix this problem

ActorMike · Feb 18, 2023

htsumer said:
Waiting for an update to fix this problem

I did what @Chris D suggested and it worked for me- https://xenforo.com/community/threads/batch-update-users-broken-in-2-2-12.211063/post-1610382

htsumer · Feb 18, 2023

ActorMike said:
I did what @Chris D suggested and it worked for me- https://xenforo.com/community/threads/batch-update-users-broken-in-2-2-12.211063/post-1610382

That topic is a solution to another problem. My problem is in bulk updates