[Banxix] Auto Close Threads 1.0.1 Patch 2

[Banxix]

See here demo: https://drive.google.com/file/d/1MI8SgOfNs3W6H9xTEjH5Gpio-bvj7wyf/view?usp=sharing

It's better now, thank you. I will test and make a fix.

 

[Banxix]

Banxix updated [Banxix] Auto Close Threads with a new update entry:

1.0.1 Patch 1

Fix reply count factor is always triggered.

Read the rest of this update entry...

 

[Wutime]

Your thread view return null on $thread which should be \XF\Entity\Thread. I'm afraid it is not my addon's fault.

I implement a small fix for you. It check if the $thread is instance of Thread, but since your $thread is null, the auto close is not triggered.

I'm getting the identical error, ONLY when this addon is enabled.

 

[Wutime]

@Banxix I've been able to suppress the error by doing the following:

Editing /Banxix/AutoCloseThreads/XF/Entity/Thread.php line 56 with:

        else
        {
            if (isset($entity->post_date)) {
                if ($entity->post_date + (\XF::options()->autoCloseThreadsTimeFactorMinutes * 60) < time())
                {
                    $this->threadStateClosed();
                }
            }

        }

 

[Banxix]

@Banxix I've been able to suppress the error by doing the following:

Editing /Banxix/AutoCloseThreads/XF/Entity/Thread.php line 56 with:

        else
        {
            if (isset($entity->post_date)) {
                if ($entity->post_date + (\XF::options()->autoCloseThreadsTimeFactorMinutes * 60) < time())
                {
                    $this->threadStateClosed();
                }
            }

        }

Thank you, I missed the case where entity does not exist (for some reaons, because it should always exist). This fix should be enough.

 

[Banxix]

Banxix updated [Banxix] Auto Close Threads with a new update entry:

1.0.1 Patch 2

Fixed a case where entity does not exist (it should always exist)

Read the rest of this update entry...

 

[Oblivion Knight]

Query count shoots up with this add-on enabled..

News and announcements

umbrella-online.co.uk

Queries with add-on enabled: 36
Queries with add-on disabled: 19

 

[unproperlypropagated]

Query count shoots up with this add-on enabled..

News and announcements

umbrella-online.co.uk

Queries with add-on enabled: 36
Queries with add-on disabled: 19

Query: None

I guess we were lied to.