Fixed b4 js problem in acp

[ragtek]

As you see the last / is missing....


Possible fix:

    protected function processJsUrls(array $jsFiles)
    {
        // add version number to each required file
        foreach ($jsFiles AS &$file)
        {
            $file = $file . (strpos($file, '?') ? '&' : '?') . '_v=' . XenForo_Application::$jsVersion;
        }

        // source XenForo JS from 'js/xenforo/x/' if required
        switch (XenForo_Application::get('options')->uncompressedJs)
        {
            case 1:
                $jsFiles = str_replace('js/xenforo/', 'js/xenforo/full/', $jsFiles);
                break;

            case 2:
                $jsFiles = str_replace('js/xenforo', 'js/xenforo/min/', $jsFiles);
                break;
        }

        // handle custom JS URL
        return preg_replace('#^js/#', XenForo_Application::$javaScriptUrl . '/', $jsFiles);
    }

then it's working in the acp, but in the frontend the url is:

 

[Floris]

XenForo doesn't come with the /min/ directory - which is why they are not found.

 

[Floris]

In the upgrade package that I used, I also do not see the fullcache_rebuild.js file.

 

[ragtek]

it's only cache_rebuild.js and should be full/cache_rebuild.js

In the upgrade package that I used, I also do not see the fullcache_rebuild.js file.

 

[Kier]

I'm not sure how that function got so messed up. Fixed now.

 

[Alluidh]

Does this help? http://xenforo.com/community/threads/xenforo-1-1-0-beta-4-released.22207/#post-278982

 

[CTXMedia]

I'm not sure how that function got so messed up. Fixed now.

Has the download package been updated?

 

[Floris]

And, if we already have upgraded, should we re-do it? Or can we just replace a file and rebuild caches somehow?

 

[Kier]

Here is the fix:

 

[DSF]

Is this fixed in the download?

 

[Floris]

Thanks!

 

[Kier]

Is this fixed in the download?

No. It will not affect most customers.

 

[infis]

If you see message when appling patch: (Stripping trailing CRs from patch.) - and patch not appling.
You are can install tofrodos (in Debian/Ubuntu - sudo apt-get install tofrodos) and use it as:

serv:# fromdos changeset_5065.diff
serv:# fromdos Abstract.php
serv:# patch < changeset_5065.diff
serv:# todos Abstract.php

 

[Andrej]

EDIT: Question revoked, I found it out!

 

[Floris]

I hope seeing it visual like this perhaps makes more sense:



You can either manually find the old code, and replace it with the new code.
Or load the old file in a diff handler and parse it with the .diff that Kier provided.

 

[Andrej]

I hope seeing it visual like this perhaps makes more sense:

View attachment 20625

You can either manually find the old code, and replace it with the new code.
Or load the old file in a diff handler and parse it with the .diff that Kier provided.

This is even better explanation. Thank you.

 

[DSF]

Sorry, but this procedure is like the old BB-Boards and must be a outdated game.

 

[ragtek]

But it's still a beta

 

[DSF]

But it's still a beta

Just beta is a possibility to present a modern update-style.
This is like a kitchen. Take a little bit salt and take a little bit sugar and then backed with 220 degree. Ooooh no!

 

[Floris]

So rather than not hearing from the developers at all, who just reply (if you're lucky) pointing to "this is beta, we dont' support it) they (within a couple of minutes) provide a patch .. and you whine about it.