Fixed "API key copied to clipboard." not phrased

[DragonByte Tech]

Affected version

2.1.0 RC2

In template admin:api_key_macros, the data-success="API key copied to clipboard." should be phrased and escaped with |for_attr

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.0 RC3).

Change log:

Add missing phrase on the API key copy button.

Any changes made as a result of this issue being resolved may not be rolled out here until later.

 

[Chris D]

should be phrased and escaped with |for_attr

This shouldn't be necessary as the phrase is being used on an XF tag. Attributes on XF template tags are generally escaped automatically. Additional escaping could cause certain characters to be double-escaped.

 

[DragonByte Tech]

This shouldn't be necessary as the phrase is being used on an XF tag. Attributes on XF template tags are generally escaped automatically. Additional escaping could cause certain characters to be double-escaped.

Interesting, thanks for the heads up

Today has already been very educational regarding double escaping, learned about \XF\PreEscaped and now this