Ads Manager 2 by Siropu [Paid] 2.5.8

[Siropu]

However, this problem disappears when the ad banner added using your plugin is removed.

Errors are not from the add-on itself but from the ads.

 

[hakyangler]

Errors are not from the add-on itself but from the ads.

there is also no problem when I add ads manually, just so you know. this is due to your plugin.

 

[SpecialK]

@Siropu - I have a Banner package in a position on the site, but I now need to add a Code ad in that same position (In rotation with the already defined banner ads). Is this not possible? Every time I activate the code ad in that position, it shows an ad from the banner package AND my code ad, instead of just showing one or the other.

 

[Siropu]

there is also no problem when I add ads manually, just so you know. this is due to your plugin.

Are you adding them in the same positions? Does it require a global script in the head of the page? My add-on just inserts the code in the template, not changing anything.

Is this not possible?

Just use a banner ad and add your code in the "Custom HTM" field of it.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Bug Fixes

Fixed keyword ads not working in custom fields thread_view template.
Fixed an issue with extending ads not working with sticky and promo thread ad type.

Read the rest of this update entry...

 

[Andy.N]

@Siropu
I remember you mentioned this in the past but I couldn't find the details how to implement this.
If I have bannerA and bannerB that I want to upload for the same add so that I can do a A/B comparison between the banners. How can set it up?
I understand that if I upload multiple banner for one specific add, it will rotate among those banners?

 

[Siropu]

I understand that if I upload multiple banner for one specific add, it will rotate among those banners?

Yes. Enable stats to see which one performs better.

 

[Andy.N]

Would you support each banner has its own click through url for finer tracking?
For example, for a leaderboard add, I may have 2 banners of size 728x90 and 2 banners of 2x sizes. Each banner has a different tracking/click through URL so that advertisers know exactly what banners got click on.
Right now, all of those 4 banners all go through the same URL.

 

[Siropu]

If you enable Click stats you can see which banner was clicked on.

 

[Max Fridman]

@Siropu if i set a CSS Class for a package, the ads created should have it applied automatically right?

 

[Siropu]

the ads created should have it applied automatically right?

No. The css class you set in the package is for the unit container not for individual ads.

 

[Max Fridman]

No. The css class you set in the package is for the unit container not for individual ads.

So its impossible to apply a css class for every ads in a package?

 

[Siropu]

So its impossible to apply a css class for every ads in a package?

If you have a css class for package, you can use it to style ads as well in your .less template like so:

.myClass
{
     // package css
    
     > div
     {
          // ad css
     }
}

 

[briansol]

Since updating to latest, i'm logged a few of these on REALLY long image names.


XF\Db\Exception: MySQL query error [1406]: Data too long for column 'page_url' at row 1 src/XF/Db/AbstractStatement.php:230
Generated by: Unknown account May 26, 2025 at 9:11 PM
Stack trace
INSERT INTO xf_siropu_ads_manager_click_fraud
(ad_id, ip, page_url, log_date, click_count)
VALUES
(?, ?, ?, ?, ?)
ON DUPLICATE KEY UPDATE
click_count = click_count + 1,
page_url = CONCAT(page_url, 'https://mydomain.com/media/10392077_101437823203174_4375890_n.5690/ \n ')

------------

#0 src/XF/Db/Mysqli/Statement.php(207): XF\Db\AbstractStatement->getException('MySQL query err...', 1406, '22001')
#1 src/XF/Db/Mysqli/Statement.php(83): XF\Db\Mysqli\Statement->getException('MySQL query err...', 1406, '22001')
#2 src/XF/Db/AbstractAdapter.php(96): XF\Db\Mysqli\Statement->execute()
#3 src/addons/Siropu/AdsManager/Repository/ClickFraud.php(20): XF\Db\AbstractAdapter->query('
...', Array)
#4 src/addons/Siropu/AdsManager/Pub/Controller/Ad.php(484): Siropu\AdsManager\Repository\ClickFraud->logClick(19, 'https://hondasw...')
#5 src/XF/Mvc/Dispatcher.php(362): Siropu\AdsManager\Pub\Controller\Ad->actionMonitorClick(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(264): XF\Mvc\Dispatcher->dispatchClass('Siropu\\AdsManag...', 'MonitorClick', Object(XF\Mvc\RouteMatch), Object(Siropu\AdsManager\Pub\Controller\Ad), NULL)
#7 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(Siropu\AdsManager\Pub\Controller\Ad), NULL)
#8 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2826): XF\Mvc\Dispatcher->run()
#10 src/XF.php(806): XF\App->run()
#11 index.php(23): XF::runApp('XF\\Pub\\App')
#12 {main}
Request state
array(4) {
["url"] => string(36) "/index.php?sam-item/19/monitor-click"
["referrer"] => bool(false)
["_GET"] => array(1) {
["sam-item/19/monitor-click"] => string(0) ""
}
["_POST"] => array(0) {
}
}

 

[Automotive101]

hiya @Siropu , running version 2.5.7
for the stats, it is only showing logged in user stats, does not reflect any guest stats ?
if this is a setting, then I have not found it
can you advise

 

[USY]

Hey,

I just try to your website for a support request since I am your client.
But once I logged in, I get ?

 

[Siropu]

Since updating to latest, i'm logged a few of these on REALLY long image names.

Can you check in phpmyadmin for table xf_siropu_ads_manager_click_fraud what type is field page_url? Make it text type if it is not.

if this is a setting, then I have not found it

There is no other setting. I don't see any issues in my tests with guest click stats.

But once I logged in, I get ?

Everything seems to work ok. Do you still have the issue?

 

[briansol]

It is text.


The table is empty now.

My guess is since i had a bunch of errors for this same page, it overflowed on concat'ing the url over and over again to the tune of 65k+ chars.

I guess there's nothing to fix here, maybe change to longtext but it's likely overkill.

 

[Siropu]

I will validate the URL before inserting it and limit it at certain length.