Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.4.22

No permission to buy (€49.99)
Downloaded again this morning, and I get three errors:

Code:
Server error log
ErrorException: [E_NOTICE] Undefined index: siropuAdsManagerAdvertisersWidget src/addons/Siropu/AdsManager/Repository/Ad.php:81
Generated by: Pete Thomas Jul 23, 2018 at 8:43 AM
Stack trace
#0 src/addons/Siropu/AdsManager/Repository/Ad.php(81): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/caf/publi...', 81, Array)
#1 src/addons/Siropu/AdsManager/Repository/Ad.php(136): Siropu\AdsManager\Repository\Ad->getWidgetsCacheData()
#2 src/addons/Siropu/AdsManager/Setup.php(538): Siropu\AdsManager\Repository\Ad->rebuildWidgetsCache()
#3 src/XF/AddOn/StepRunnerUpgradeTrait.php(122): Siropu\AdsManager\Setup->upgrade2011070Step1(Array)
#4 src/XF/AddOn/StepRunnerUpgradeTrait.php(71): Siropu\AdsManager\Setup->upgradeStepRunner(2011070, 1, Array, NULL)
#5 src/XF/Admin/Controller/AddOn.php(449): Siropu\AdsManager\Setup->upgrade(Array)
#6 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\AddOn->actionUpgrade(Object(XF\Mvc\ParameterBag))
#7 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:AddOn', 'Upgrade', 'html', Object(XF\Mvc\ParameterBag), 'listAddOns', Object(XF\Admin\Controller\AddOn), NULL)
#8 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(44) "/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["referrer"] => string(73) "https://xf2.cafesaxophone.com/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["_GET"] => array(1) {
    ["add-ons/Siropu-AdsManager/upgrade"] => string(0) ""
  }
  ["_POST"] => array(7) {
    ["_xfProcessing"] => string(1) "1"
    ["continue"] => string(1) "1"
    ["confirm"] => string(1) "1"
    ["params"] => string(31) "{"step":1,"version_id":2011070}"
    ["count"] => string(1) "2"
    ["finished"] => string(1) "0"
    ["_xfToken"] => string(8) "********"
  }
}

Code:
Server error log
ErrorException: [E_NOTICE] Undefined index: siropuAdsManagerFeaturedThreadsWidget src/addons/Siropu/AdsManager/Repository/Ad.php:82
Generated by: Pete Thomas Jul 23, 2018 at 8:43 AM
Stack trace
#0 src/addons/Siropu/AdsManager/Repository/Ad.php(82): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/caf/publi...', 82, Array)
#1 src/addons/Siropu/AdsManager/Repository/Ad.php(136): Siropu\AdsManager\Repository\Ad->getWidgetsCacheData()
#2 src/addons/Siropu/AdsManager/Setup.php(538): Siropu\AdsManager\Repository\Ad->rebuildWidgetsCache()
#3 src/XF/AddOn/StepRunnerUpgradeTrait.php(122): Siropu\AdsManager\Setup->upgrade2011070Step1(Array)
#4 src/XF/AddOn/StepRunnerUpgradeTrait.php(71): Siropu\AdsManager\Setup->upgradeStepRunner(2011070, 1, Array, NULL)
#5 src/XF/Admin/Controller/AddOn.php(449): Siropu\AdsManager\Setup->upgrade(Array)
#6 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\AddOn->actionUpgrade(Object(XF\Mvc\ParameterBag))
#7 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:AddOn', 'Upgrade', 'html', Object(XF\Mvc\ParameterBag), 'listAddOns', Object(XF\Admin\Controller\AddOn), NULL)
#8 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(44) "/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["referrer"] => string(73) "https://xf2.cafesaxophone.com/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["_GET"] => array(1) {
    ["add-ons/Siropu-AdsManager/upgrade"] => string(0) ""
  }
  ["_POST"] => array(7) {
    ["_xfProcessing"] => string(1) "1"
    ["continue"] => string(1) "1"
    ["confirm"] => string(1) "1"
    ["params"] => string(31) "{"step":1,"version_id":2011070}"
    ["count"] => string(1) "2"
    ["finished"] => string(1) "0"
    ["_xfToken"] => string(8) "********"
  }
}

Code:
xServer error log
ErrorException: [E_NOTICE] Undefined index: siropuAdsManagerFeaturedResourcesWidget src/addons/Siropu/AdsManager/Repository/Ad.php:83
Generated by: Pete Thomas Jul 23, 2018 at 8:43 AM
Stack trace
#0 src/addons/Siropu/AdsManager/Repository/Ad.php(83): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/caf/publi...', 83, Array)
#1 src/addons/Siropu/AdsManager/Repository/Ad.php(136): Siropu\AdsManager\Repository\Ad->getWidgetsCacheData()
#2 src/addons/Siropu/AdsManager/Setup.php(538): Siropu\AdsManager\Repository\Ad->rebuildWidgetsCache()
#3 src/XF/AddOn/StepRunnerUpgradeTrait.php(122): Siropu\AdsManager\Setup->upgrade2011070Step1(Array)
#4 src/XF/AddOn/StepRunnerUpgradeTrait.php(71): Siropu\AdsManager\Setup->upgradeStepRunner(2011070, 1, Array, NULL)
#5 src/XF/Admin/Controller/AddOn.php(449): Siropu\AdsManager\Setup->upgrade(Array)
#6 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\AddOn->actionUpgrade(Object(XF\Mvc\ParameterBag))
#7 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:AddOn', 'Upgrade', 'html', Object(XF\Mvc\ParameterBag), 'listAddOns', Object(XF\Admin\Controller\AddOn), NULL)
#8 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(44) "/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["referrer"] => string(73) "https://xf2.cafesaxophone.com/admin.php?add-ons/Siropu-AdsManager/upgrade"
  ["_GET"] => array(1) {
    ["add-ons/Siropu-AdsManager/upgrade"] => string(0) ""
  }
  ["_POST"] => array(7) {
    ["_xfProcessing"] => string(1) "1"
    ["continue"] => string(1) "1"
    ["confirm"] => string(1) "1"
    ["params"] => string(31) "{"step":1,"version_id":2011070}"
    ["count"] => string(1) "2"
    ["finished"] => string(1) "0"
    ["_xfToken"] => string(8) "********"
  }
}
 
A few more are popping up now.

e.g. on creating an ad

Code:
Server error log
ErrorException: [E_NOTICE] Undefined index: display_after src/addons/Siropu/AdsManager/Entity/Ad.php:201
Generated by: Curtis Jul 23, 2018 at 9:26 AM
Stack trace
#0 src/addons/Siropu/AdsManager/Entity/Ad.php(201): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/caf/publi...', 201, Array)
#1 src/addons/Siropu/AdsManager/Pub/Controller/Ad.php(99): Siropu\AdsManager\Entity\Ad->inheritPackage()
#2 src/XF/Mvc/Dispatcher.php(249): Siropu\AdsManager\Pub\Controller\Ad->actionSave(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('Siropu\\AdsManag...', 'Save', 'json', Object(XF\Mvc\ParameterBag), 'siropuAdsManage...', Object(Siropu\AdsManager\Pub\Controller\Ad), NULL)
#4 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#5 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#6 src/XF.php(328): XF\App->run()
#7 index.php(13): XF::runApp('XF\\Pub\\App')
#8 {main}
Request state
array(4) {
  ["url"] => string(23) "/ads-manager/ads/0/save"
  ["referrer"] => string(62) "https://xf2.cafesaxophone.com/ads-manager/packages/2/create-ad"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(13) {
    ["name"] => string(9) "curtis926"
    ["target_url"] => string(24) "https://petethomas.co.uk"
    ["discount"] => string(0) ""
    ["purchase"] => string(3) "100"
    ["alert_notification"] => string(1) "1"
    ["notes"] => string(0) ""
    ["package_id"] => string(1) "2"
    ["terms_agreement"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["save"] => string(9) "undefined"
    ["_xfRequestUri"] => string(33) "/ads-manager/packages/2/create-ad"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}
 
Last edited:
@Mr Lucky, rebuild add-on data. Those admin options exists.
As for the last error, edit the package(s) (code, banner, text, link) without changing anything and save. It will update the settings.
 
@Mr Lucky, rebuild add-on data. Those admin options exists.
As for the last error, edit the package(s) (code, banner, text, link) without changing anything and save. It will update the settings.

OK I found rebuild. I did a reupgrade (rolled back database and files on my development site.

After re-upgrade to 2.1.1 and rebuild I am still getting the widget errors.
 
After re-upgrade to 2.1.1 and rebuild I am still getting the widget errors.
That's very strange because I have tested the upgrade on my demo site and I don't see any issues with that. Make sure that every file is overwritten when uploading them.
Do I edit the packages after rebuild or before?
Doesn't meter. display_after is a package setting that has been added in 2.1.0 not in 2.1.1
 
Just tried again and edited the packes, all fine now when creating an ad, but I still got the three widget erros./ Is that something I need to worry about?

Doesn't meter. display_after is a package setting that has been added in 2.1.0 not in 2.1.1

I upgraded direct from 2.0.5 to 2.1.1

Is that a problem?
 
So after you have rebuilt the add-on master data, do you still get those 3 errors? I find that very strange. I have done a test where I have removed from the database an admin option and after I have rebuilt the add-on data, the option has been added back. I have no idea why it doesn't work for you. To prevent these errors from showing up, you can disable the 3 widgets from the widgets area.
 
So after you have rebuilt the add-on master data, do you still get those 3 errors?

I'm not quite understanding.

The 3 errors are there as soon as I install, before rebuilding the master data so after rebuilding the same ones are still there.

No new ones after rebuilding or after editing packages or after creating an ad. Just when installing.
 
Top Bottom