Partial fix Active Upgrades are not cleared upon deleteing User Upgrade

[TickTackk]

Affected version

2.*

Steps to reproduce:

1. Add a new user upgrade named "X"
2. Let user named "Y" purchase user upgrade "X"
3. Delete user upgrade named "X"

You should be able to see active user upgrades for "X"

 

[Chris D]

FWIW, it looks like we didn't in XF1 either. This may indicate it was deliberate, though the only reason I can think that would be the case is to maintain a rough audit trail, though there is little benefit in that, IMO.

We'll give it some thought. At the very least, we'll probably either change the UserUpgrade join to required here or at least display 'N/A' for the upgrade title.

 

[Chris D]

They will no longer be displayed in the UI, but we're still not deleting them.