1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed 1.3: Google login does not work from overlay

Discussion in 'Resolved Bug Reports' started by Arty, Feb 14, 2014.

  1. Arty

    Arty Well-Known Member

    Google login link does not work from login overlay, the one that uses helper_login_form.html

    How to test it:
    1. Fill in Google auth settings to enable Google login.
    2. Change login button to trigger overlay instead of dropdown form. Follow this tutorial or simply add class OverlayTrigger to login button.
    3. Try to log in with Google.
     
    RoldanLT and bortrenamo like this.
  2. RoldanLT

    RoldanLT Well-Known Member

    Maybe because of this? CSRF token
     
  3. Arty

    Arty Well-Known Member

    No, JavaScript is missing. Link itself is a <span> element that cannot be clicked, XenForo is supposed to attach onclick event to it, but it doesn't attach one for overlay.
     
    RoldanLT and bortrenamo like this.
  4. Mike

    Mike XenForo Developer Staff Member

    This is fixed now. We don't directly add a click handler -- it's actually the Google API that does, though we need to identify what needs it and load it if necessary. We needed to add that handling to the standard XenForo JS "activation" system.
     

Share This Page