Xon has improved the cache for the Bb Codes map by creating a "non-cached tag map on thread preview". Purpose: Allow protected content to show up in the thread/post preview ; if you have a Bb Code which can only be used by a group, a member of that group can see what it looks like when they preview a post.
Xon has also proceeded to a few modifications to improve performance
Some Bb Codes (such as some of the the Bbm Advanced Bb Codes) might use an helper that check the integrity of the Bb Codes content after some modifications have been done. There are two ways of checking the content html:
One is done with the PHP Dom functions ; that's the default one and should work on installations with PHP 5.3.x at least
The other is done by an external class, it had some bugs (it was trying to do too much whereas it was not necessary). They have been fixed.
There's now an option to select which method you want to use. Again, the first one (PHP Dom) should not cause any issue. I've tested it quite a lot with the addon ToggleMe.
There was a fix for the replacement method fix: when a Bb Code coded with this method had a wrapper Bb Code, the index option was missing, so a conditional has been updated to avoid this. T Thanks to Gossamer.
I think that's all for this commit, Xon again did a lot, if I've missed something, he will tell me and I will add it here
Xon added a cache system for the tags map. It must be enabled inside the options. Explanation: when a page is parsed, the Bbm creates a map of all the tags with their personal data. This operation can be intensive (it depends on how many Bb Codes there are), the cache system allows to improve performance.
For Bb Code developers (from a Xon idea): add a uniqid function in the formatter (can be called from the callback). Purpose: avoid to use the intensively the php uniqid function (source)
Hide XenForo button when its XenForo Bb Code parsing permission (based on the Visitor object) is disabled. Only works with the following Bb Codes : email, url, img & media. The "targeted nodes" option is ignored (can get node information in this part of the script).
Some events are now using hints to improve performance (done by Xon)
Note: Xon is now a contributor on the Github branch, which means he should now have access to version on Github and update it if needed. You can fully trust his commits: he's serious & reactive, knows how to code very well and always take care of improving performance. A big thank to him.
Add a function to check buttons when saving a configuration. This will prevent to register any invalid buttons
Fix a Redactor plugin problem to be sure it loads on any browsers:
On Chrome, the Redactor plugin JS object was loaded before the editor configuration initialization. On Firefox, it was the opposite. Thanks to Case
Fix and update the mini-parser (related to Bb Code protection) to prevent a malformed closing tag to break the page layout Thanks to Case
XenForo Custom Bb Codes buttons can be managed directly in the BBM Buttons Manager, for both editors: XenForo Redactor & TinyMCE Quattro.
With the XenForo Redactor editor, once the button positioned inside the Bbm config, the new location will override the original location that should have had this button
With the TinyMCE Quattro editor, the XenForo Custom Bb Code button action will only be to insert the tag inside the editor, which means if a developer had coded a custom callback for this Redactor button, he will have to code it as well for the TinyMCE Quattro framework (which won't be a problem at all). They will have their original icon
Bbm Bb Codes can set a "text button" for the XenForo Redactor editor. For the TinyMCE Quattro editor this feature has been there since the beginning.
Bbm Bb Codes can have a button using a Font-Awesome icon for both editors. An helper has been created to make the selection easier
Modification done to the code to avoid bugs with other addons - Thanks to Pegasus
Modification done to one Bb Code helper - Thanks to Xon - implementation of a function to tidy html code
Improvement of the Buttons Manager Tooltip (disable during sorting operation)
Notes:
this version has been tested on a fresh install & during an update
The TinyMCE Quattro addon will have to be updated to support new functions. The update is ready. It will be released in a few minutes.
Improve xml security on XenForo installations that have been updated with the Zend xml tester. To be clear: there was only a risk if you imported a malicious BbCode xml. So if you download files from authenticated developers, it's not a problem. If you didn't have updated to the last XenForo patched versions, this xml Bbm BbCodes importation will still work: it's up to you to decide to update XenForo or not.
The tags map is now compatible with the preCacheBase system: the tags incremention data has to be reset before the loop. With this you can also get the post information (ie: postid) during the second loop. Info: I will publish a demonstration of a Bb Code using this preCache system which advantage is for example to only use 1 database request instead of several by page. See attached images.
