Alert Improvements by Xon 2.13.0

• Fix "getSvAlertPref(): Return value must be of type array, null returned" when adding a user via the admincp
• Force a consistent mysql locking ordering of affected user records when a user receives a reaction

• Fix adding a user via the admincp could result in a php type error

• Fix alerts grouped by user could occur event if the alerts by a user was less than the configured threshold
• Fix new installs did not migrate alert preferences
• Fix migrating alert preferences would block the installer
• Fix alert preferences where not respected during alert migration from stock to add-on configuration
• Adjust text around the alert pop-up marking alerts as read behavior
• Use a separate css class for the recent alert marker
• Convert confusing named "Alerts pop-up does not mark alerts as read" checkbox to "Alert pop-up read behavior" with the options: "Always mark alerts as read"/"Never mark alerts as read"/"Use per-alert configuration"
• Add style properties "Show recent/unread alert icon on alert" and "Unread/Recent alert icon", disabled by default (previously was enabled)

Thanks to @NamePros for sponsoring this update.

• Work-around surprisingly expensive add-on live-ness join when fetching alerts and instead filter by content_type
• Fix some bad index selection for newer MariaDB/MySQL versions for various parts of the add-on
• Fix some bad performance when using the 'unsummarize' feature
• Fix bad links for profile-post summary alerts
• Fix formatting of alert summarization threshold option not being a numberbox
• Fix summary alerts could have a "G" as the user avatar for alerts which aren't attributed to a user
• Style compatibility fix where the day-selector on the alerts page could be forced onto a new line
• Rework alert summarization feature to be more performant and use less memory
• Rework alert preferences
  • Cleanup various phrasing and add more explainer text to hopefully be less confusing
  • Add "Alerting preference defaults" option
  • Add simplified interface for alert preferences (no alerts, use defaults, use custom).
  • Add per-alert "Alert bell read" option to alert preferences which allows setting if each individual alert is mark-as-read when viewed in the alerts pop-up
• Add support for summarizing XFMG reactions alerts
• Add support for summarizing post quotes alerts
• Add support for summarizing user followed alerts

Spoiler: Screenshots

This add-on is now available on atelieraphelion.com

• Fix "Alerts pop-up skips mark read" and "Alerts page skips summarizing" user-options did not save as expected
• Fix "Alert resummarize flood check" global option didn't allow selecting 0 to disable it

• Fix regression in v2.9.0 where empty content summary alerts was being generated, and incorrectly preferring a per-user summary instead
• Fix that editing alert preferences when summarization is disabled, would disable some summarization options

• Fix both the alerts pop-up and alerts page would mark some alerts as read when it shouldn't.
  This could give the impression of alerts disappearing as the default unread filter on the alerts page would exclude those unexpectedly read alerts

• Require Standard Library by Xon v1.18.0+
• Fix alert summarizing only triggered on +25 unread alerts instead of the user-defined threshold
• Fix summary alerts in the alert pop-up would be pushed under the just read alerts as if it had been read a while ago
• Adjust "Alert summarize limit" option description text to better describe what a limit of 0 does (ie no limit)

• Fix "Alert summarization" option being disabled still showed user's preference options to configure it

• Require php 7.2+
• Require XenForo 2.2+, remove XF2.1 support
• Fix sticky unread alerts could unexpectedly occur due to (effectively undocumented) 'auto read' functionality in XF2.2
• Fix confusion over view_date vs read_date not being correctly used in the expected places
• Fix alerts pop-up not respecting "Days to retain viewed alerts in popup" option in all cases
• Fix 'mark read' functionality could result in inconsistent view/read date for older alerts near the expiry period
• Fix unstaller not correctly removing columns added to xf_user_option
• Fix alert summarization/grouping may not trigger when expected
• Ensure xf_user_alert.summerize_id column has the same column size as xf_user_alert.alert_id. If alert_id has been to a bigint, this may be an expensive operation.
  • The following SQL schema change is executed if the alert_id column has been manually changed:
    SQL:

    alter table xf_user_alert modify column summerize_id bigint unsigned  default null;

• Use index hints to control poor index selection on some installs
• Attempt to improve unviewed alert cleanup which can have issues when dealing with very large number of alerts
• Improve UI.X compatibility
• In Alerts pop-up, do not prevent marking alerts as recently read when they are read in that request
• Add various styling options to control alerts styling
• Add styling option to control if just-read-alerts from the alerts pop-up are styled as read or unread, and if to fade from unread to read.
• Visiting the full alerts page no longer marks alerts as read by default, and removes the relevant per-user option ("Alerts page skips mark read").
• Display an font-awesome icon (star with exclamation) on alerts which are unread with auto-read off, rather than a star for recent-ish alerts. With more correct hint text on both