Not a bug XFES and/or XFMG upgrade to 2.3.5 Produces ACP error

[ichpen]

Affected version

2.3.5

Below was produced right after I did XF 2.3.4 -> 2.3.6 and subsequently updated XFMG and XFES to 2.3.5. Not quite sure which of the updates trigered it as I usually select both.

• ErrorException: File clean up job failed for XF due to write permissions. Legacy files may need to be cleaned up manually.
• src/XF/Error.php:81
• Generated by: Unknown account
• Feb 22, 2025 at 4:41 PM

Stack trace​

#0 src/XF.php(266): XF\Error->logError(Object(XF\Phrase), false)
#1 src/XF/Job/FileCleanUp.php(115): XF::logError(Object(XF\Phrase))
#2 src/XF/Job/FileCleanUp.php(52): XF\Job\FileCleanUp->stepDeleteFiles(7.59891)
#3 src/XF/Job/Manager.php(275): XF\Job\FileCleanUp->run(7.59891)
#4 src/XF/Job/Manager.php(205): XF\Job\Manager->runJobInternal(Array, 7.59891)
#5 src/XF/Job/Manager.php(89): XF\Job\Manager->runJobEntry(Array, 7.59891)
#6 job.php(46): XF\Job\Manager->runQueue(false, 8)
#7 {main}

Request state​

array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(44) "https://mysite.com/admin.php"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

 

[Jeremy P]

This won’t be a bug. We try to clean up files from old versions after upgrading, but if PHP/XF doesn’t have the correct file permissions, this will be logged for your information.

You can clean them up manually with the CLI command if you want.

 

[ichpen]

This won’t be a bug. We try to clean up files from old versions after upgrading, but if PHP/XF doesn’t have the correct file permissions, this will be logged for your information.

You can clean them up manually with the CLI command if you want.

Fair enough, what's the clean up command in question?

Also, I have no permission changes whatsoever to PHP/FPM, been running this VM for years through many upgrade lifecycles and this is the first time I hit this error so I'm thinking you're trying to clean something new here with 2.3.X?

 

[Jeremy P]

On mobile so not sure off-hand, but you can run php cmd.php list to see a list of all of them.

And yeah, we didn’t attempt to clean up old files at all on previous versions.

 

[ichpen]

On mobile so not sure off-hand, but you can run php cmd.php list to see a list of all of them.

And yeah, we didn’t attempt to clean up old files at all on previous versions.

Aha interesting...

Is it xf:file-clean-up perchance?

 

[Jeremy P]

Probably.

 

[Thangvip9x]

Please run via the CLI

php cmd.php xf:file-clean-up XF