[XFA] Media Of The Month - XF2

[XFA] Media Of The Month - XF2 [Paid] 4.5.2

No permission to buy (€15.00)
Overview Updates (24) Reviews (3) History Discussion
Oh ok I see.

I am currently working on Extended moderation porting, MOTM is next on the list.
 
XFA updated [XFA] Media Of The Month - XF2 with a new update entry:

4.5.0 - Port to XF2.3, bug fix and new features

Corrected bugs:
  • ErrorException: Template error: [E_WARNING] Attempt to read property "xfa_motm" on null src/addons/XFA/XFMGMediaOfTheMonth/XFMG/Entity/MediaItem.php:50

Modifications:
  • Updated table names to XF standard
  • Add-on ported to XF2.3
  • Revamped options organisation

New features:
  • Mode 1: Maximum file size option
  • Mode 1: Maximum image dimensions option

This version is only compatible with...
Click to expand...

Read the rest of this update entry...
 
Just posting that this add-on is not working for me on 2.3.6. Trying to work with the developer to find a fix.

Would appreciate knowing if it is working for anyone else on this Xenforo version.
 
The Awarded slider media widget queries xf_mg_media_item where xfa_motm_winnner = 1.
As there is no usable index this query scans the whole table which is very slow when there are many records.

Suggested Fix
Create an appropriate index
or
Store media item IDs for winners somewhere else

The Current contest slider media Widget seems to have similar issues (I didn't specifically test this, just looked at the code).
 
  • Like
Reactions: XFA
I would love something like this for my forum. But it seems support is somewhat lacking? Does it work at all in XF 2.3.7?
 
This one has indeed not been implemented but I didn't consider it as actually a bug rather an improvement.
 
Bug Report

Affected Version: 4.5.1
Since XenForo 2.3.7, XF corrected the behavior of option values so that they are now returned in their correct data types.
X

Fixed Thread 'XF options do not round-trip integer/boolean values as expected'

PHP: 
var_dump(\XF::Options()->changeLogLength);

$option = Helper::find(\XF\Entity\Option::class, 'changeLogLength');
$option->option_value = 0;
var_dump($option->option_value);

Both of these will output a string type instead of the expected int type. This matters because xf-dev:generate-options-stub CLI command gives strongly typed hints, and phpstorm (and other php code formatting tools) will suggest to unwrap any casts. Except the underlying type is stringy so strict checks (=== / !==) will unexpectedly fail.

The solution appears for...
  • Like

File:
XFA\XFMGMediaOfTheMonth\Cron\XFMGMediaOfTheMonth.php
Line: 205
PHP: 
$monthDay === $motmDayStart

Problem:

$motmDayStart is now correctly returned as an integer.
$monthDay is always a string derived from the methods:

PHP: 
$language->date()
or
$date->format()

Because of this, a strict comparison fails.

Suggested Fix:
Ensure both variables use the same data type before comparison for example:
PHP: 
(int)$monthDay === (int)$motmDayStart
 
You must log in or register to reply here.
Back
Top Bottom