Fixed [XF2.1] Media item list overlay is not counting new reactions

[marquisite]

Affected version

2.x/2.1

I tried out reacting to a media item (Wow, and Like) and in both cases the reaction count on the item's overlay is not updating. Example:


Prior to my reaction testing, this media item had one like (dated pre-XF2.1)

 

[Mike]

Out of the box, "Wow" is a neutral reaction (as it's meaning can be both good and bad). So this is correct -- that is showing the reaction score itself.

Saying that, I'll leave this open as because reactions are more generic, that icon may be misleading (though I'm not sure what else we may use).

 

[marquisite]

Good point about the neutral score. This said, I've changed my reaction to 'Like' yet the overlay reaction score still shows as 1.

The media item if you'd like to look further is: https://xenforo.com/community/media/a-fiancé’s-christmas-present-to-her-husband.2097/

 

[Mike]

There was an underlying bug here that we've fixed related to score calculation. I'll still leave this open for now though.

 

[Chris D]

I'm just going to mark this fixed as there's not really any more we can do here above and beyond the changes we made to ensure this was being calculated correctly. The concept of the reaction score being made up of reactions that may be positive, negative or neutral (or indeed have a score weighted more than one) is just something we have to get used to vs. the simpler like count approach.