Fixed XF\Navigation\NodeType::loadPendingNodeData always loads child nodes

[Xon]

Affected version

2.0.12

The new navigation system allows to bind to a given node, with the option "Display children in navigation" default-disabled.

However, all child nodes of a node are always loaded even if display is disabled.

 

[ge66]

I do not exactly know if this is related.
When I updated to 2.0.12 my two node menues with child nodes did not show up at all.
I tested to change a setting for the node menu and it showed up. On the other I just disabled it and enabled it again and then it showed up.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.1.0 Beta 6).

Change log:

Don't load child nodes from the database if they aren't being displayed with the navigation entry.

Any changes made as a result of this issue being resolved may not be rolled out here until later.