Not a bug XF\Cli\Command\AddOnActionTrait: save result of $importFromOutput for later

[MaGeFH]

Affected version

Public Beta 5

While working on importing custom add-on data I stumbled across this one.

If you need to do a re-import after installing the addon, you need the information if the user wanted to import from xml or from dev output. This will be asked in XF\Cli\Command\AddOnActionTrait::importAddOnData, but the answer is discarded afterwards. If you need to import at the end of the end in XF\AddOn\AbstractSetup::postInstall you cannot access the answer to this question and asking again is kind of meh...

 

[Mike]

This isn't really a bug -- at best, it'd be a suggestion. But equally, I don't think it's something we'd really be looking to implement. This sort of extension of add-on associated data isn't something that I'd say is something we're explicitly targeting. We wouldn't really want to be passing this sort of state into the postX methods either.

Though I will say that we don't ask this question any longer. The CLI will always use development data if it's available.

 

[MaGeFH]

Though I will say that we don't ask this question any longer. The CLI will always use development data if it's available.

Good to hear, that solves my problem as well. ;-)