• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed XenForo_Helper_Php attempts to validate empty callbacks

Chris D

XenForo developer
Staff member
#1
During add-on install/upgrade in XF 1.3, if the XML file contains a BB Code Media Site with empty match and embed callback classes, the above class attempts to validate those empty strings which results in a failure.
 

Mike

XenForo developer
Staff member
#2
I think failing to validate an empty callback is fine -- the calling code has the option to skip it if necessary. However, I did accidentally change the logic in the media site DW to not check for a class before attempting to validate the callback. I changed the DW back to only validate it if there is one.
 

Blatchy

Active member
#3
I think failing to validate an empty callback is fine -- the calling code has the option to skip it if necessary. However, I did accidentally change the logic in the media site DW to not check for a class before attempting to validate the callback. I changed the DW back to only validate it if there is one.
Is there a simple fix that can be applied now instead of waiting for the next beta release?