• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed XenForo_ControllerPublic_EditHistory::_getHistoryOr404

xf_phantom

Well-known member
#1
1.It's not returning 404, it's returning error code 403 for registered users (because getNoPermissionResponseException is being used for all the error messages, even if the history record wasn't found)


2. It's not following the XF Naming convention:p All other methods use getFooOrError or assertFooValidAndViewable and not getFooOr404:p :cautious::rolleyes:
 
Last edited:

Kier

XenForo Developer
Staff member
#2
I've adjusted the naming to _getHistoryOrError, and changed the error that is thrown when history is not found to a 404, but the remaining two errors (content type handler not found and no permission to view history) remain throwing getNoPermissionResponseException.