1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed XenForo_ControllerPublic_EditHistory::_getHistoryOr404

Discussion in 'Resolved Bug Reports' started by xf_phantom, Jul 9, 2013.

  1. xf_phantom

    xf_phantom Well-Known Member

    1.It's not returning 404, it's returning error code 403 for registered users (because getNoPermissionResponseException is being used for all the error messages, even if the history record wasn't found)

    2. It's not following the XF Naming convention:p All other methods use getFooOrError or assertFooValidAndViewable and not getFooOr404:p :cautious::rolleyes:
    Last edited: Jul 9, 2013
    Adam Howard, SneakyDave and AlexT like this.
  2. Kier

    Kier XenForo Developer Staff Member

    I've adjusted the naming to _getHistoryOrError, and changed the error that is thrown when history is not found to a 404, but the remaining two errors (content type handler not found and no permission to view history) remain throwing getNoPermissionResponseException.
    AlexT and xf_phantom like this.

Share This Page