Closed XenForo_ControllerAdmin_User::actionEmailSend doesn't use XenForo_Mail

Jeremy

Jeremy

in memoriam 1991-2020
Licensed customer
It uses XenForo_Mail::getDefaultTransport(), but not XenForo_Mail::create() which is consistent everywhere else. Not sure if a mis-code or as designed. Thought it weird to use Zend_Mail here.
 
Do you mean actionEmailSend?:D (at least that's the name in my file^^)
and in
XenForo_ControllerAdmin_User::_sendEmail XenForo_Mail isn't even used.
It's just
PHP: 
$mailObj = new Zend_Mail('utf-8');
$mailObj->setSubject($email['email_title'])
->addTo($user['email'], $user['username'])
->setFrom($email['from_email'], $email['from_name']);
 
Yes, yes I did. XenForo_ControllerAdmin_User::_sendEmail proxy uses XenForo_Mail in the $transport.
 
This is intentional. I'm assuming that there's a suggestion here, but you might want to make another thread for that. :)
 
Not really. I was just looking through code and noticed this was one spot where it wasn't used. Thought I'd throw it out there. :) any particular reason why?
 
I'm also interested into the reason, because it is IMO a bug.

If i use a proxy mail class to use a own transport (what i'm doing), it won't have any effect in this case and will use the default xenforo configuration instead of my "injected" transport object


(good that i never used the acp mail feature:D )
 
Back
Top Bottom