[Xen-Soluce] SEO Optimization

[Xen-Soluce] SEO Optimization [Paid] 2.7.0 Fix 4

No permission to buy (€25.00)
Overview Updates (35) Reviews (3) History Discussion
Because when you save a thread, you save all the associated fields, so you won't gain anything by leaving them as they are, or not, as they may still be processed unnecessarily in the code. Also, this is to avoid errors such as "Can't read title on NULL" (title is an example) etc. To avoid this, you can indeed check if such and such a field exists, but this would add to the completion of the field for nothing.
Click to expand...

Sorry, this is no reason!

It needs only some lines to check if the fields are empty, if so you can save "[]"
If not you can do a cron job one time at night.
Or a cache job, so people can do it one time in a month.
 
Robert9 said:
Sorry, this is no reason!

It needs only some lines to check if the fields are empty, if so you can save "[]"
If not you can do a cron job one time at night.
Or a cache job, so people can do it one time in a month.
Click to expand...
I have a question for you: what difference does it make to you whether it's there or not?
Robert9 said:
Who am I to tell you how to make an add-on ... :)

But maybe you will start with a list first and make a concept, here is what I would like to have:
ogi = og:image

XF default ogi

xf forum list ogi
xf forum ogi per forum = could be the default ogi for all threads in this forum OR
xf forum ogi as default for all threads

threads like now, but please check if attachments are working? Maybe set a hint for 851*315 (correct size?)

xf rm overview ogi
xf rm cat ogi per cat= could be the default ogi for all resources in cat OR
xf rm cat ogi as default for all resources

Please check if attachments are working? Maybe set a hint for 851*315 (correct size?)

icon makes no sense as long small?


Perfect, but maybe overkill: Choose one attachment for threads and resources




For the XF default ogi, you have to check if it is set or not!


And maybe there is another problem!
When using an og:image with 851*315 it is correct as og:image, but if you open your browser and see the list of domains you have visited last time, then this picture is used as a quadrat, means it looks wrong. I have seen this today, while i experiment with three different forums, so I could see the icon used for them and this list in the browser, when have a 851*315 instead 800*800, it looks wrong.
Click to expand...
Please download the latest version ;) (2.6.3 Fix 1)
 
I have the latest version on a client page. All the problems I have mentioned are happened in this latest version!

I have a question for you: what difference does it make to you whether it's there or not?
Click to expand...

I don't like it when every single thread and resource, we talk about ten thousands at client server are using bytes in their database without any need.

I can give you the question back: What is the problem with adding some lines like

is the array empty? then save "[]", else save array?

If you think bigger, then you are maybe responsible for millions of threads and resources, saving around 120 bytes without any need.
And again: because we miss some fewer lines like:

is the array empty? then save "[]", else save array?


It is your add-on, do what you want, I can add a con job for my clients to get rid of this, but somehow it feels strange that a programmer asks such a question.
 
Robert9 said:
I have the latest version on a client page. All the problems I have mentioned are happened in this latest version!
Click to expand...
On your admin panel, which version is it? It says that you've had no license since November 11, 2022.
Robert9 said:
I don't like it when every single thread and resource, we talk about ten thousands at client server are using bytes in their database without any need.

I can give you the question back: What is the problem with adding some lines like

is the array empty? then save "[]", else save array?

If you think bigger, then you are maybe responsible for millions of threads and resources, saving around 120 bytes without any need.
And again: because we miss some fewer lines like:

is the array empty? then save "[]", else save array?


It is your add-on, do what you want, I can add a con job for my clients to get rid of this, but somehow it feels strange that a programmer asks such a question.
Click to expand...
You're right, these fields should be columns.
 
There are some issues in latest version you may want to solve.

There is no og:image for cats and forums in source code.
it is not enough to add this to the template mods because xf also add og:image if the default og:image is set.
So you have to add the template mod and have to care if the xf default is set or not.

Your phrases are wrong, we don't care for threads in rm cats.
Also, you have to know if this og:image in cats/forums is only for the cat/forum or also default for res/threads.

You should also care for forum home and rm overview.

I am not sure if the attachments are working, i will watch for this not now, but now it is not used.

In my forum I have an older version, I only use it for the title/description; there was no need for og:image until now.
In my client's forum there is a need for og:image, this is why I care now for a half day to understand what's wrong with your add-on.
 
What do you think about an upload of the og:image to a directory /og with name = title_words_connected_with as a suggested filename? It is so anoying to upload pictures somewhere, and add the url into the thread.
 
Hello,

Robert9 said:
What do you think about an upload of the og:image to a directory /og with name = title_words_connected_with as a suggested filename? It is so anoying to upload pictures somewhere, and add the url into the thread.
Click to expand...
Yes indeed, it's in the projects!

Regards, CRUEL-MODZ
 
Can you please check the OG for threads;
I have checkboxed attachments, but the source code of threads shows something like this:

Code: 
https://www.forum.com/https://www.forum.com/data/attachments/32/32370-cbd5be37eee42e3820f8ee6d1a1f17.jpg

I have not tested yet:
You may, should allow showing the attachment as og:image by options when the there is no permission to view for guests?
Maybe i want to use the first picture as og:image, but dont allow guests to see any pictures in the forum itself.
 
Last edited:
Robert9 said:
I have not tested yet:
You may, should allow showing the attachment as og:image by options when the there is no permission to view for guests?
Maybe i want to use the first picture as og:image, but dont allow guests to see any pictures in the forum itself.
Click to expand...
Ah yes, this may pose a problem for the og:image, you may have to install this addon: https://xenforo.com/community/resources/xen-soluce-display-visitor-attachments.7602/ But given the link you gave me, it doesn't explain this
 
How can I use the attachment itself as ig:image and not the thumbnail?
Makes no sense to use 150 pixel for og from my point of view
 
This is your story, but do you really want people to install another add-on to make this add-on working?

attachments for guests in the forum: NO!
attachments as og: yes, sure, else it makes no sense to use it.
also use the attachment itself and not the thumb for og.
 
Ok, i have checked you twitter:image in seo_macros and the other in metadata_macros;
seems the template mod is not working here;
will check in a minute.

Do you have any idea about the original attachment and how to use it for og?
 
Robert9 said:
This is your story, but do you really want people to install another add-on to make this add-on working?

attachments for guests in the forum: NO!
attachments as og: yes, sure, else it makes no sense to use it.
also use the attachment itself and not the thumb for og.
Click to expand...
As a robot is a guests , technically this rebot must have access as a guests ....

I'm just giving you a solution, then we'll have to see how to allow the attachment specified in the meta to have access as a guest.
 
When i search for "twitter:image" I find two of them; one in the original macro, one in yours.
If I change this to "twodder:image" and "twammer:image"; i should find one of them in my source-code?

There are two other add-ons, one for SEO, one for OG: I will remove them now ...
 
Nothing with that add-ons.

Maybe I should say, that I dont talk about the og:image now!
I talk about twitter:image!

I have removed now the two twitter:image lines in the templates; funny, funny, again it is a cache-problem.
The og:image is fine;
 
Yes, as said, it is again a cache-problem; this browser will bring me to grave one day.
But from where could come this {board_url}{attach_url}

And do you have added any trigger for full_attach and thumb?
There is no trigger in XF, right?
 
Ok, here what I have found:

for full and thumb, please be so kind and add a trigger for

Code: 
public function getAttachment($attachments, $default, $canViewAttachment)

in the AbstractHandler


The problem with {boardurl}/attach_url is only visible for a guest, not when I am logged in.

If I change your code here:
Code: 
                if($attachment->has_thumbnail)
                {
                    $imageUrl = rtrim(\XF::app()->request()->getHostUrl(), '/') . '/' . ltrim($attachment->thumbnail_url, '/');

                    if($canViewAttachment)
                    {
                        $imageUrl = \XF::app()->router()->buildLink('full:attachments', $attachment);
                    }

//added by r9
                    $imageUrl = \XF::app()->router()->buildLink('full:attachments', $attachment);
//
                    return $imageUrl;
                }

there is no prblem; so maybe ...

the problem is here?

Code: 
$imageUrl = rtrim(\XF::app()->request()->getHostUrl(), '/') . '/' . ltrim($attachment->thumbnail_url, '/');
 
You must log in or register to reply here.

Similar threads

D
[Xen-Soluce] SEO Optimization - FRENCH translation [Deleted]
Replies
3
Views
535
Ozzy47
Ozzy47
XenSoluce
[Xen-Soluce] Service System [Paid]
Replies
9
Views
805
XenSoluce
XenSoluce
XenSoluce
[Xen-Soluce] Social Locker [Paid]
Replies
6
Views
846
SyTry
SyTry
Back
Top Bottom