XAR - Attachment [Deleted]

[rdn]

To ensure you match how XenForo serves files, add the following headers into your site config where appropriate:

add_header X-Frame-Options SAMEORIGIN;
add_header X-Content-Type-Options nosniff;

Seems

add_header X-Frame-Options SAMEORIGIN;

Is not needed since it's default on XenForo or else it will result duplicate header?

 

[Xon]

Seems

add_header X-Frame-Options SAMEORIGIN;

Is not needed since it's default on XenForo or else it will result duplicate header?

IIRC my testing showed that nginx stripped that header on the internal redirect.

 

[rdn]

To ensure you match how XenForo serves files, add the following headers into your site config where appropriate

So how did you add it?
On what location?
I just add it on top of my server block.
Below server_name.

 

[Xon]

So how did you add it?
On what location?
I just add it on top of my server block.
Below server_name.

Ah, yes that would cause duplicates. It can also cause issues with attachments sorry.

I've got this code block:

  location ^~ /internal_data/ {
  add_header X-Frame-Options SAMEORIGIN;
  add_header X-Content-Type-Options nosniff;
  internal;
  }

The internal directive means it can only be accessed via internal redirects, and the "^~" means this only matches things which start with that path, and it should be before any php, or image handling blocks.

I've updated the initial documentation with that.

 

[rdn]

Here's what I have right now:

location /internal_data {
        location ~ \.(data|html|php)$ {
        internal;
        }
    internal;
    }

So I will change it to:

location /internal_data {
        location ~ \.(data|html|php)$ {  
add_header X-Frame-Options SAMEORIGIN;
add_header X-Content-Type-Options nosniff;
        internal;
        }
    internal;
    }

Right?

 

[Xon]

Right?

Correct. It is the .data files which end up being served after the addon does it stuff.

 

[MattW]

Is there any reason why this doesn't work when XenForo is in a folder, and not the document root?

        location /forum/ {
                try_files $uri $uri/ /forum/index.php?$uri&$args;
                location /forum/internal_data {
                        location ~ \.(data|html|php)$ {
                                add_header X-Frame-Options SAMEORIGIN;
                                add_header X-Content-Type-Options nosniff;
                                internal;
                        }
                        internal;
                }
                location /forum/library {
                        location ~ \.(default|html|php|txt|xml)$ {
                                internal;
                        }
                        internal;
                }
        }

All attachments return 404 not found when enabled.

 

[Xon]

Is there any reason why this doesn't work when XenForo is in a folder, and not the document root?

Can you try adding the following to your config.php:

config['internalDataUrl'] = '/forum/internal_data';

What is suspect is happening is the disk-layout doesn't match the URL layout.

 

[MattW]

Can you try adding the following to your config.php:

config['internalDataUrl'] = '/forum/internal_data';

What is suspect is happening is the disk-layout doesn't match the URL layout.

Perfect!

 

[Xon]

Perfect!

I've updated the addon overview to better explain the requirement of 'internalDataUrl' when XenForo isn't in the webroot.

 

[Axel B]

Thanks @Xon! @MattW made sure your addon worked on my little VPS

 

[Coop1979]

How does this integrate with [bd] Attachment Store?

https://xenforo.com/community/resources/bd-attachment-store.1779/

 

[Axel B]

I have [bd] Attachment Store and Xar up and running as of today. Haven't really done a thorough investigation on what the performance upgrade is. Not sure which one is the biggest improvement on performance. I have 54k of attachments on my site.

 

[Xon]

How does this integrate with [bd] Attachment Store?

https://xenforo.com/community/resources/bd-attachment-store.1779/

If you have [bd] Attachment Store, then this addon doesn't do anything.

If you configure [bd] Attachment Store to store in the public /data you lose the permission checks this addon permits but have equivalent performance (php isn't involved in downloading the file.

 

[Axel B]

@Xon, I don't fully understand all the technical details, but is there a way to also benefit from the XAR addon when [bd] Attachment Store is installed?

 

[Xon]

@Xon, I don't fully understand all the technical details, but is there a way to also benefit from the XAR addon when [bd] Attachment Store is installed?

The XAR addon addon simply isn't needed if [bd] Attachment Store is installed, and set to a non-default storage option.

Keep in mind; that the non-default storage options in [bd] Attachment Store removes the ability to permission check attachments.

 

[Axel B]

@Xon, I use the default storage option I run a minimal setup of 2Core, 2Gb Memory and 40Gb SSD from DigitalOcean.
Don't think the permission checks are really important on my forum. 99,9% of the pictures are about Maine Coons (cat breed)

Thanks for your replies!

 

[rdn]

On this resource overview:

config['internalDataUrl'] = '/forum/internal_data';

Should be:

$config['internalDataPath'] - default: 'internal_data'

Right?

 

[Xon]

Xon updated XAR - Attachment with a new update entry:

Debugging support

Support for logging of the XAR redirection url in debug mode (new debug-mode only option).

Read the rest of this update entry...

 

[rdn]

With this addon enabled, [Tinhte] Attach Image Optimization is useless?