Cannot reproduce When XF2 addon has same version_id as XF1 addon, both are displayed under legacy addons

[W1zzard]

Affected version

2.0.0

Both have version_id 2.
XF2 is version_string "2.0.0", XF1 is "1.0.1".

Should probably show some kind of error message to highlight the issue.

Maybe also add a check in cli xf:addon-create after entering legacy id

 

[DragonByte Tech]

Both have version_id 2.

Version ID:
This integer will be used for internal version comparisons. Each release of your add-on should increase this number.

Fillip

 

[W1zzard]

Of course, I'm aware of that. Just failed at ++

 

[Chris D]

I can't actually reproduce this.

I manually inserted an add-on into the DB as follows:

addon_id: OldAddOn
title: Blah
version_string: 1.0.0
version_id: 1
active: 0
is_legacy: 1

Then I created an add-on using the CLI:
addon_id: NewAddOn
title: Blah
version_string: 2.0.0
version_id: 1
(Specified that it supersedes OldAddOn)

All this does is rename the original add-on to have the new add-on ID and version details (which is correct, if you're a developer starting locally, there's no point in making you go through the upgrade process).

Now, I'm not certain if any of the steps I've taken are different, so maybe that will need clarifying, but otherwise the only way I can see this happening is if there was some sort of duplicate entry in the DB, perhaps with slightly different casing on the add-on ID or something like that.