Closed Video attachments should be opened in lightbox

Kirby

Well-known member
Licensed customer
Affected version
2.3.6
If the lightbox is enabled, a user uploads an image to a post and does not embed it into the post, the image opens in the lightbox.
If the user does the same with a video, the video does not open in the lightbox but as a new window / tab.

This seems inconvenient and inconsistent, especially as videos in XFMG are opened in the lightbox.
 
If the lightbox is enabled, a user uploads an image to a post and does not embed it into the post, the image opens in the lightbox.
If the user does the same with a video, the video does not open in the lightbox but as a new window / tab.

This seems inconvenient and inconsistent, especially as videos in XFMG are opened in the lightbox.
It's crazy that it's been 14 years and still no one figured this out, now just you and me. I couldn't fix the video embed pop-up of lightbox / fancybox that doesn't work on the resource manager and XenForo self. But the media gallery does work when I visit https://xenforo.com/community/media/?type=video

This video embed needs to be supported by XenForo and XFRM self, or just fix both bugs ifit isn't showing up and force you to redirect to open a new tab of the video.

Dear @Chris D , @Jeremy P, Are you going to take a look at this issue? :(
 
We have 100,000 embeded videos in posts, user either embeds it and it plays or clicks to open attached file it in their browser. The hell do we want a lightbox for? Pretty JavaScript?
 
We have 100,000 embeded videos in posts, user either embeds it and it plays or clicks to open attached file it in their browser. The hell do we want a lightbox for? Pretty JavaScript?
Of course, opening a video with a lightbox is more important than opening a new tab. I'm surprised XFMG still exists with video lightbox support. But XF self and XFRM still haven't been fixed, or both need to support video lightbox because that is more than 14 years.
 


Threads/posts are now supported for video and audio lightbox. This is the finish of work.

Happy Good Morning GIF by The Swoon
 
Automated triage: Design issue

Thank you for reporting this issue. Video attachments that aren't embedded are shown as a preview that links to the file in a new tab. The core lightbox only handles image attachments, so opening videos in it would be a design change rather than a fix for a defect.

This is an automated assessment. A member of staff may review and update it.
 
Automated triage: Design issue

Thank you for reporting this issue. Video attachments that aren't embedded are shown as a preview that links to the file in a new tab. The core lightbox only handles image attachments, so opening videos in it would be a design change rather than a fix for a defect.

This is an automated assessment. A member of staff may review and update it.
I disagree with leaving this behaviour as it is. It is inconsistent: images open in a lightbox, while video attachments open a new tab, even though Media Gallery supports video lightboxes.

Please add a UserCP or AdminCP option to choose whether video attachments open in a new tab or play in a lightbox, for both threads and Resource Manager. If this belongs under suggestions, could it be moved there for consideration?
 
We’ll be leaving bug reports where they are as they contain useful historical information. But it certainly is a valid suggestion.
 
Back
Top Bottom