Fixed Vbulletin 5: Closures table gets double prefixed

[Slavik]

As title:

XF\Db\Exception: MySQL statement prepare error [1146]: Table 'db.vb_vb_closure' doesn't exist src/XF/Db/AbstractStatement.php:217
Generated by: Unknown account Jan 3, 2019 at 12:58 PM
Stack trace
            SELECT
                node.nodeid AS forumid,
                node.parentid, node.urlident, node.title, node.description, node.displayorder,
                node.textcount AS threadcount,
                node.totalcount - node.textcount AS replycount,
                node.lastcontent AS lastpost,
                node.lastcontentauthor AS lastposter,
                IF(node.displayorder > 0, 1, 0) + IF((channel.category = 1 OR node.parentid = 1), 0, 4) AS options
            FROM vb_node AS
                node
            INNER JOIN vb_channel AS
                channel ON (channel.nodeid = node.nodeid)
                INNER JOIN vb_vb_closure AS
                    closure ON (closure.child = node.nodeid)
                WHERE node.nodeid <> 2
                AND node.urlident <> 'vbcms-comments'
                AND closure.parent = ?
            AND channel.category <> IF(node.parentid = 1, 0, -1)
            ORDER BY node.parentid, node.displayorder
        
------------

#0 src/XF/Db/Mysqli/Statement.php(196): XF\Db\AbstractStatement->getException('MySQL statement...', 1146, '42S02')
#1 src/XF/Db/Mysqli/Statement.php(39): XF\Db\Mysqli\Statement->getException('MySQL statement...', 1146, '42S02')
#2 src/XF/Db/Mysqli/Statement.php(54): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(89): XF\Db\Mysqli\Statement->execute()
#4 src/XF/Db/AbstractAdapter.php(116): XF\Db\AbstractAdapter->query('
            SELECT
                ...', Array)
#5 src/addons/XFI/Import/Importer/vBulletin5.php(474): XF\Db\AbstractAdapter->fetchAllKeyed('
            SELECT
                ...', 'forumid', Array)
#6 src/addons/XFI/Import/Importer/vBulletin.php(2082): XFI\Import\Importer\vBulletin5->getForums(Array)
#7 src/XF/Import/Runner.php(160): XFI\Import\Importer\vBulletin->stepForums(Object(XF\Import\StepState), Array, 8)
#8 src/XF/Import/Runner.php(74): XF\Import\Runner->runStep('forums', Object(XF\Import\StepState), 8)
#9 src/XF/Cli/Command/Import.php(66): XF\Import\Runner->run()
#10 src/vendor/symfony/console/Command/Command.php(255): XF\Cli\Command\Import->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 src/vendor/symfony/console/Application.php(953): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 src/vendor/symfony/console/Application.php(248): Symfony\Component\Console\Application->doRunCommand(Object(XF\Cli\Command\Import), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 src/vendor/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 src/XF/Cli/Runner.php(63): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#15 cmd.php(15): XF\Cli\Runner->run()
#16 {main}

 

[Mike]

It looks like we just don't need to apply the prefixing at the early point, so this should be resolved for the next XFI release.