Fixed XFI vBulletin: Undefined array key "topicactiondelay" when importing RSS Feeds

Kirby

Well-known member
Licensed customer
Affected version
1.5.1
Code:
#0 src/addons/XFI/Import/Importer/vBulletin.php(2905): XF::handlePhpError(2, '[E_WARNING] Und...', '/var/www/vhosts...', 2905)
#1 src/XF/Import/Runner.php(244): XFI\Import\Importer\vBulletin->stepFeeds(Object(XF\Import\StepState), Array, 8)
#2 src/XF/Import/Runner.php(61): XF\Import\Runner->runStep('feeds', Object(XF\Import\StepState), 8)
#3 src/XF/Import/Runner.php(154): XF\Import\Runner->run()
#4 src/XF/Import/ParallelRunner.php(41): XF\Import\Runner->runUntilCompleteInternal(Object(XF\Import\Manager), Object(Closure))
#5 src/XF/Import/Runner.php(130): XF\Import\ParallelRunner->runUntilCompleteInternal(Object(XF\Import\Manager), Object(Closure))
#6 src/XF/Cli/Command/Import.php(156): XF\Import\Runner->runUntilComplete(Object(XF\Import\Manager), Object(Closure))
#7 src/vendor/symfony/console/Command/Command.php(255): XF\Cli\Command\Import->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 src/vendor/symfony/console/Application.php(992): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 src/vendor/symfony/console/Application.php(255): Symfony\Component\Console\Application->doRunCommand(Object(XF\Cli\Command\Import), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 src/vendor/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 src/XF/Cli/Runner.php(111): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 cmd.php(15): XF\Cli\Runner->run()
#13 {main}

PHP:
$import->discussion_open = !($this->bitwise($feed['options'], 4) && $feed['topicactiondelay']);

A standard vBulletin (4) schema (taken from vBulletin 4.2.5) does not have a field topicactiondelay:
PHP:
$schema['CREATE']['query']['rssfeed'] = "
CREATE TABLE " . TABLE_PREFIX . "rssfeed (
    rssfeedid INT UNSIGNED NOT NULL AUTO_INCREMENT,
    title VARCHAR(250) NOT NULL DEFAULT '',
    url TEXT,
    port SMALLINT UNSIGNED NOT NULL DEFAULT '80',
    ttl SMALLINT UNSIGNED NOT NULL DEFAULT '1500',
    maxresults SMALLINT NOT NULL DEFAULT '0',
    userid INT UNSIGNED NOT NULL DEFAULT '0',
    forumid SMALLINT UNSIGNED NOT NULL DEFAULT '0',
    prefixid VARCHAR(25) NOT NULL DEFAULT '',
    iconid SMALLINT UNSIGNED NOT NULL DEFAULT '0',
    titletemplate MEDIUMTEXT,
    bodytemplate MEDIUMTEXT,
    searchwords MEDIUMTEXT,
    itemtype ENUM('thread','announcement') NOT NULL DEFAULT 'thread',
    threadactiondelay SMALLINT UNSIGNED NOT NULL DEFAULT '0',
    endannouncement INT UNSIGNED NOT NULL DEFAULT '0',
    options INT UNSIGNED NOT NULL DEFAULT '0',
    lastrun INT UNSIGNED NOT NULL DEFAULT '0',
    PRIMARY KEY (rssfeedid),
    KEY lastrun (lastrun)
)
";
$schema['CREATE']['explain']['rssfeed'] = sprintf($vbphrase['create_table'], TABLE_PREFIX . "rssfeed");

So most likely this should be threadactiondelay?
 
Thank you for reporting this issue, it has now been resolved.

Change log:
Read the feed thread action delay from the correct column
There may be a delay before changes are rolled out to the XenForo Community.
 
Back
Top Bottom