• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed vBulletin 4.x Import: [QUOTE] tags broken

Affected version
2.0.0
#1
Code:
diff --git a/xenforo/src/XF/Import/Importer/vBulletin.php b/xenforo/src/XF/Import/Importer/vBulletin.php
--- a/xenforo/src/XF/Import/Importer/vBulletin.php
+++ b/xenforo/src/XF/Import/Importer/vBulletin.php
@@ -2641,7 +2648,7 @@ class vBulletin extends AbstractForumImporter
                 $re1,
                 function ($match)
                 {
-                    return sprintf('[QUOTE="%s, post: %d]',
+                    return sprintf('[QUOTE="%s, post: %d"]',
                         $match['username'],
                         $this->lookupId('post', $match['postid'])
                     );
The importer turns this:
[QUOTE=Nickname;1234]Text[/QUOTE]

Into this (note the missing " character):
[QUOTE="Nickname, post: 1234]Text[/QUOTE]

PS: When I move the diff from the start to the end of this post then the formatting is broken.