Fixed vBulletin 4.x Import: [QUOTE] tags broken

[Steffen]

Affected version

2.0.0

diff --git a/xenforo/src/XF/Import/Importer/vBulletin.php b/xenforo/src/XF/Import/Importer/vBulletin.php
--- a/xenforo/src/XF/Import/Importer/vBulletin.php
+++ b/xenforo/src/XF/Import/Importer/vBulletin.php
@@ -2641,7 +2648,7 @@ class vBulletin extends AbstractForumImporter
                 $re1,
                 function ($match)
                 {
-                    return sprintf('[QUOTE="%s, post: %d]',
+                    return sprintf('[QUOTE="%s, post: %d"]',
                         $match['username'],
                         $this->lookupId('post', $match['postid'])
                     );

The importer turns this:
[QUOTE=Nickname;1234]Text[/QUOTE]

Into this (note the missing " character):
[QUOTE="Nickname, post: 1234]Text[/QUOTE]

PS: When I move the diff from the start to the end of this post then the formatting is broken.

 

[Kier]

Fixed that now.

 

[jokeroo]

How do you fix this after the import is complete?

 

[Steffen]

I'd dump the import and run it again with this fix applied (and maybe even wait for XenForo 2.0.1 with more importer fixes). I hope this was a test import.

 

[jokeroo]

That would be too difficult to redo, the board is massive and everything is running smoothly again, just need to fix this.

 

[Kier]

You could potentially use the content find/replace add-on with a regular expression to find the broken quote tags?