Fixed vB4 Import: Don't import all Forum Watches with Alerts enabled

[Steffen]

I think the current behaviour in generall is surprising for users coming from vBulletin 4 and maybe overwhelming for users with lots of watched forums.

Maybe only enable alerts if email updates are enabled?

diff --git a/src/addons/XFI/Import/Importer/vBulletin.php b/src/addons/XFI/Import/Importer/vBulletin.php
index 406f1a3e2..106432805 100644
--- a/src/addons/XFI/Import/Importer/vBulletin.php
+++ b/src/addons/XFI/Import/Importer/vBulletin.php
@@ -2664,7 +2664,7 @@ class vBulletin extends AbstractForumImporter
     {
         return [
             'notify_on' => 'thread',
-            'send_alert' => true,
+            'send_alert' => ($emailUpdate > 0),
             'send_email' => ($emailUpdate > 0)
         ];
     }

 

[Kier]

Fair enough.