Fixed vB4 Import: Always treat "Re:" as a valid reply title prefix

[Steffen]

Our vBulletin "reply_prefix" phrase is set to "AW:" but very old posts use "Re:" as a reply title prefix. Maybe this was a hard-coded prefix in vB2/vB3. Maybe we changed it. I cannot say this for sure anymore but I think it's sane and safe to always treat "Re:" as a possible reply title prefix.

diff --git a/src/addons/XFI/Import/Importer/vBulletin.php b/src/addons/XFI/Import/Importer/vBulletin.php
index d2da9180d..e8f713a44 100644
--- a/src/addons/XFI/Import/Importer/vBulletin.php
+++ b/src/addons/XFI/Import/Importer/vBulletin.php
@@ -3777,9 +3777,9 @@ class vBulletin extends AbstractForumImporter
                     FROM phrase
                     WHERE varname = 'reply_prefix'
                 "));
-                if (!$this->session->extra['reply_prefixes'])
+                if (!in_array('Re:', $this->session->extra['reply_prefixes']))
                 {
-                    $this->session->extra['reply_prefixes'] = ['Re:'];
+                    $this->session->extra['reply_prefixes'][] = 'Re:';
                 }
             }

 

[Steffen]

By the way, I think you've missed the following follow-up post in a fixed thread with an additional patch: https://xenforo.com/community/threa...tpostmessage-seems-broken.144015/post-1232591

 

[Kier]

All sorted.