Fixed [USER] BB-Code -> negative User-ID

[nocte]

Look what happens when I do this:

[USER=-123]test[/USER]

test

Shouldn't there be an other error message ("invalid User ID")?

 

[Chris D]

Are you referring to the message:

This was posted by a guest who does not have a profile to view.

I think the user ID is being cast to an unsigned integer, 0, therefore assuming we're dealing with a guest user.

It's really quite an unexpected thing to happen; usually the user bb code would be generated via a user mention where there's no chance of this happening, but clearly it could be confusing.

 

[nocte]

Are you referring to the message:

yes!

Surely it's not a big thing. Just wanted to report it

 

[digitalpoint]

Might be worthwhile to have a better error message... If you go to a user profile with a user ID under 1, you get the same message about it being posted by a guest. What exactly was posted by a guest here? lol

https://xenforo.com/community/members/0/

"invalid user" would be a better error I think.

 

[Mike]

I've fixed this now. It won't generate a link in this case.