Third party Token Input Validation Issues

[Jonathan M]

Affected version

2.2.5

Validation in token inputs is broken in 2 related but different ways.

Replication steps:

1. Open a thread.
2. Press the edit tags icon.
3. Press comma twice.

This will insert a comma tag which should be disallowed because a comma plus spaces is the delimiter for token inputs.

Replication steps:

1. Open a thread.
2. Press the edit tags icon.
3. Press comma and any single letter.
4. Let the results load.
5. Press comma.

This will add a tag with a comma in it. This also should be disallowed for the same reason as above.

 

[Chris D]

Aside from the slight weirdness in the display, does this actually cause any issues in practice?

Without looking, I think the worst it does is potentially create a string with an extra comma in it which perhaps produces an empty string value when converted to an array so in all likelihood that just gets skipped without issue.

On the whole I'm not sure we're able to make any changes here anyway because it looks like a behaviour inherent in the underlying library so I don't think we'll be able to do much to workaround this.

 

[Jonathan M]

No, this issue doesn't actually cause a problem after the user submits the form.

I don't think the issue is present in Select2 though, at least, based on the examples on this page.

 

[Chris D]

It can be reproduced on this example - automatic tokenization is the feature we use:

Dynamic option creation | Select2 - The jQuery replacement for select boxes

Select2 is a jQuery based replacement for select boxes. It supports searching, remote data sets, and pagination (infinite scrolling) of results.

select2.org

I think we'll close it for now but it might be worth posting an issue over at their GitHub.