Fixed Thread deletes if deleted post is moves into it

[Azaly]

Affected version

2.1.5

If in some thread one moderator (or user himself) delete post while second moderator at the same time decide to move it into another thread, destination thread would be deleted. It also happens when one moderator first delete post and then move it.
Fortunately soft deleted threads could be restored.

 

[Paul B]

Was it the first post in the thread?

 

[Azaly]

The point is that it wasn't the first post in both threads. In destination thread it was nearly 5000th.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.6).

Change log:

When moving posts into an existing thread, ensure we only change the thread's visibility if the first source post is now the target's first post.

Any changes made as a result of this issue being resolved may not be rolled out here until later.