Not a bug The limit must be greater than zero

[TickTackk]

Affected version

2.3.0 Beta 5

Running

php cmd.php xf-addon:upgrade-step XFMG 902030031 2

Throws

Running Setup class method upgrade902030031Step2()...
In Timer.php line 21:

  The limit must be greater than zero


xf-addon:upgrade-step <id> <version> <step>

Running PHP PHP 8.3.6

 

[Chris D]

Make sure your jobMaxRunTime in config.php has a value. I guess it might be null or 0 somewhere or similar.

 

[TickTackk]

I have been using this for years

$config['jobMaxRunTime'] = php_sapi_name() === 'cli' ? 0 : (int) ini_get('max_execution_time');

but never caused any issue until now.

 

[Chris D]

It's still more common in the code base for us to use the legacy approach for doing timers. Though we usually prefer to use the XF\Timer object now and that doesn't allow a value of 0.