1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Template 'navigation' misses terms conditional

Discussion in 'Resolved Bug Reports' started by AlexT, Mar 28, 2013.

  1. AlexT

    AlexT Well-Known Member

    The header/quick links navigation of the help section misses the conditional to display a link to the Terms and Rules.

    HTML:
    <xen:hook name="navigation_tabs_help">
        <li><a href="{xen:link help/smilies}">{xen:phrase smilies}</a></li>
        <li><a href="{xen:link help/bb-codes}">{xen:phrase bb_codes}</a></li>
        <li><a href="{xen:link help/trophies}">{xen:phrase trophies}</a></li>
        <li><a href="{xen:link help/cookies}">{xen:phrase cookie_usage}</a></li>
    </xen:hook>
    should be

    HTML:
    <xen:hook name="navigation_tabs_help">
        <li><a href="{xen:link help/smilies}">{xen:phrase smilies}</a></li>
        <li><a href="{xen:link help/bb-codes}">{xen:phrase bb_codes}</a></li>
        <li><a href="{xen:link help/trophies}">{xen:phrase trophies}</a></li>
        <li><a href="{xen:link help/cookies}">{xen:phrase cookie_usage}</a></li>
    <xen:if is="{$tosUrl}">
        <li><a href="{$tosUrl}">{xen:phrase terms_and_rules}</a></li>
    </xen:if>   
    </xen:hook>
     
    erich37 likes this.
  2. Brogan

    Brogan XenForo Moderator Staff Member

    That hasn't been present since the first beta, I always assumed it was intentional.
     
  3. Jeremy

    Jeremy XenForo Moderator Staff Member

    This is most likely intentional because I don't believe $tosUrl is set in the navigation template. I'm at work so I can't look stuff up, but you could possibly reference the tosUrl option directly to display it in the main navigation.
     
  4. AlexT

    AlexT Well-Known Member

    I thought whether it was intentionally, but IMHO it doesn't seem logical. I would expect the list of links in the navigation to resemble the list of links on the left side of the help section.

    OK, you could argue that there is already a link to the Tos in the lower right footer, but that doesn't mean that there shouldn't be a link in the navigation.
     
  5. AlexT

    AlexT Well-Known Member

    It is (when you move over Help and activate it, it will be set through /library/XenForo/ControllerPublic/Help.php.
     
  6. Brogan

    Brogan XenForo Moderator Staff Member

    I did actually edit mine to include it from day 1, as it seemed a bit odd having it in the page but not on the nav bar.
     
    AlexT likes this.
  7. Jeremy

    Jeremy XenForo Moderator Staff Member

    I lied. It is exposed. I'm in agreement with AlexT here. Might also add in the <!-- slot: --> comments to match the main help page template_hook.

    I went through and tested it. Needed a break from work work.
     
  8. Mike

    Mike XenForo Developer Staff Member

    I assume it was skipped as it's in the footer, but I've changed this anyway. It does seem inconsistent.
     
    Alluidh, Slavik and erich37 like this.

Share This Page