1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Duplicate Template Modifications - dislikes <xen:comment>

Discussion in 'Resolved Bug Reports' started by Adam Howard, Jun 25, 2013.

  1. Adam Howard

    Adam Howard Well-Known Member

    So this doesn't seem to work even on the default style.

    Template in question

    sidebar_share_page

    The goal?

    Make it go bye- bye

    How?

    Wrap the whole thing with...
    PHP:
    <xen:comment>
    </
    xen:comment>
    OR as an alternative, tell XenForo's Template Modification to replace everything with an empty box.

    The results?

    Seems to apply to the master style, but never XenForo default.
     
  2. Adam Howard

    Adam Howard Well-Known Member

    Doing it manually without XenForo's Template Modifications, but directly inside the template and it works.
     
    Last edited: Jun 25, 2013
  3. Mike

    Mike XenForo Developer Staff Member

    I can't reproduce this.

    I did a find with this regex:

    Code:
    /^.*$/s
    And replace of:

    Code:
    <xen:comment>
    $0
    </xen:comment>
    And it worked on the default and a custom version of the template.

    (Same with an empty replacement.)
     
    SneakyDave likes this.
  4. Adam Howard

    Adam Howard Well-Known Member

    I was not using $0 or

    Code:
    /^.*$/s
    I did it old school and copied the whole thing in the find box, then did pasted the whole thing in the replaced box wrapped around with <xen:comment> </xen:comment>

    I deleted a post here in this bug report & now I'm thinking maybe it should have stayed...

    Is there a character limit?

    And if so, I'd call that a bug. Because there are edits that sometimes require reformatting virtually most the template. Almost replacing the whole thing, but not all of it. And rather than make a bunch of TMC entries, it would be better to make just 1.
     
  5. Mike

    Mike XenForo Developer Staff Member

    It's not a character limit. You ran into a different bug. Please re-add your customization in the latest version.

    That said, simply replacing the whole template like that sort of defeats the point of the system as a single character change would break the modification...
     
    Jeremy likes this.
  6. Adam Howard

    Adam Howard Well-Known Member

    I disagree....

    If the modification / customization requires reformatting a template with 25 (for example) different edits (or more)... It would be easier to just do 1 TMC entry vs 25 TMC entries.

    But this post was made before the release of beta 1 & 2. I'll try that.
     

Share This Page